From 3951a6f1b971ace912697f7229b71a55589b28b9 Mon Sep 17 00:00:00 2001 From: Joseph Spiros Date: Wed, 19 May 2010 05:41:32 -0400 Subject: [PATCH 1/1] Fixing a bug whereby get_path on TreeModel and Node subclasses failed if the field specified does not exist on an ancestor. --- models.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/models.py b/models.py index 1d255c7..64cf769 100644 --- a/models.py +++ b/models.py @@ -163,10 +163,10 @@ class TreeModel(models.Model): slug = models.SlugField() def get_path(self, pathsep='/', field='slug'): - path = getattr(self, field) + path = getattr(self, field, '?') parent = self.parent while parent: - path = getattr(parent, field) + pathsep + path + path = getattr(parent, field, '?') + pathsep + path parent = parent.parent return path path = property(get_path) @@ -199,10 +199,10 @@ class Node(TreeEntity): instance_type = models.ForeignKey(ContentType, editable=False) def get_path(self, pathsep='/', field='slug'): - path = getattr(self.instance, field) + path = getattr(self.instance, field, '?') parent = self.parent while parent: - path = getattr(parent.instance, field) + pathsep + path + path = getattr(parent.instance, field, '?') + pathsep + path parent = parent.parent return path path = property(get_path) -- 2.20.1