From 156ac8bc47f9ff52ff92610ae05c589b31d609e0 Mon Sep 17 00:00:00 2001 From: Stephen Burrows Date: Thu, 21 Jul 2011 16:39:28 -0400 Subject: [PATCH] Lazy-eval the values of AttributeValues instead of loading them all during AttributeMapper._fill_cache. --- philo/utils/entities.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/philo/utils/entities.py b/philo/utils/entities.py index 754a5dc..c7b14b7 100644 --- a/philo/utils/entities.py +++ b/philo/utils/entities.py @@ -1,8 +1,11 @@ +from functools import partial from UserDict import DictMixin from django.db import models from django.contrib.contenttypes.models import ContentType +from philo.utils.lazycompat import SimpleLazyObject + ### AttributeMappers @@ -91,7 +94,11 @@ class AttributeMapper(object, DictMixin): for ct_pk, pks in value_lookups.items(): values_bulk[ct_pk] = ContentType.objects.get_for_id(ct_pk).model_class().objects.in_bulk(pks) - self._cache.update(dict([(a.key, getattr(values_bulk[a.value_content_type_id].get(a.value_object_id), 'value', None)) for a in attributes])) + self._cache.update(dict([ + ( + a.key, + SimpleLazyObject(partial(getattr, values_bulk[a.value_content_type_id].get(a.value_object_id), 'value', None)) + ) for a in attributes])) self._cache_filled = True def clear_cache(self): -- 2.20.1