X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/fea69c17983d2850352261760be568e792621013..e095f691f243784f8c8d0a9773270b9dbead18e9:/models/base.py diff --git a/models/base.py b/models/base.py index ce74489..c7b1c26 100644 --- a/models/base.py +++ b/models/base.py @@ -328,9 +328,6 @@ class TreeManager(models.Manager): kwargs["%s%s__exact" % (prefix, field)] = segment prefix += "parent__" - if not prefix and root is not None: - prefix = "parent__" - if prefix: kwargs[prefix[:-2]] = root @@ -342,13 +339,15 @@ class TreeManager(models.Manager): path += pathsep return path - def find_obj(segments, depth, deepest_found): + def find_obj(segments, depth, deepest_found=None): if deepest_found is None: deepest_level = 0 - else: + elif root is None: deepest_level = deepest_found.get_level() + 1 + else: + deepest_level = deepest_found.get_level() - root.get_level() try: - obj = self.get(**make_query_kwargs(segments[deepest_level:depth], deepest_found)) + obj = self.get(**make_query_kwargs(segments[deepest_level:depth], deepest_found or root)) except self.model.DoesNotExist: if not deepest_level and depth > 1: # make sure there's a root node... @@ -359,12 +358,17 @@ class TreeManager(models.Manager): if deepest_level == depth: # This should happen if nothing is found with any part of the given path. + if root is not None and deepest_found is None: + return root, build_path(segments) raise return find_obj(segments, depth, deepest_found) else: # Yay! Found one! - deepest_level = obj.get_level() + 1 + if root is None: + deepest_level = obj.get_level() + 1 + else: + deepest_level = obj.get_level() - root.get_level() # Could there be a deeper one? if obj.is_leaf_node(): @@ -391,7 +395,7 @@ class TreeManager(models.Manager): # can be reduced. It might be possible to weight the search towards the beginning # of the path, since short paths are more likely, but how far forward? It would # need to shift depending on len(segments) - perhaps logarithmically? - return find_obj(segments, len(segments)/2 or len(segments), root) + return find_obj(segments, len(segments)/2 or len(segments)) class TreeModel(MPTTModel): @@ -400,10 +404,18 @@ class TreeModel(MPTTModel): slug = models.SlugField(max_length=255) def get_path(self, root=None, pathsep='/', field='slug'): + if root == self: + return '' + if root is not None and not self.is_descendant_of(root): raise AncestorDoesNotExist(root) - return pathsep.join([getattr(parent, field, '?') for parent in list(self.get_ancestors()) + [self]]) + qs = self.get_ancestors() + + if root is not None: + qs = qs.filter(**{'%s__gt' % self._mptt_meta.level_attr: root.get_level()}) + + return pathsep.join([getattr(parent, field, '?') for parent in list(qs) + [self]]) path = property(get_path) def __unicode__(self):