X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/d6eea439a3da7d1e3e545586a5caa4c29c2695b8..7ebd19fad0a3feffc6ed3c3917799c26aaa223d3:/philo/models/nodes.py

diff --git a/philo/models/nodes.py b/philo/models/nodes.py
index 87ccb40..9309a42 100644
--- a/philo/models/nodes.py
+++ b/philo/models/nodes.py
@@ -1,4 +1,6 @@
 from inspect import getargspec
+import mimetypes
+from os.path import basename
 
 from django.contrib.contenttypes import generic
 from django.contrib.contenttypes.models import ContentType
@@ -11,7 +13,7 @@ from django.http import HttpResponse, HttpResponseServerError, HttpResponseRedir
 from django.utils.encoding import smart_str
 
 from philo.exceptions import MIDDLEWARE_NOT_CONFIGURED, ViewCanNotProvideSubpath, ViewDoesNotProvideSubpaths
-from philo.models.base import TreeEntity, Entity, register_value_model
+from philo.models.base import SlugTreeEntity, Entity, register_value_model
 from philo.models.fields import JSONField
 from philo.utils import ContentTypeSubclassLimiter
 from philo.utils.entities import LazyPassthroughAttributeMapper
@@ -24,29 +26,33 @@ __all__ = ('Node', 'View', 'MultiView', 'Redirect', 'File')
 _view_content_type_limiter = ContentTypeSubclassLimiter(None)
 
 
-class Node(TreeEntity):
+class Node(SlugTreeEntity):
 	"""
 	:class:`Node`\ s are the basic building blocks of a website using Philo. They define the URL hierarchy and connect each URL to a :class:`View` subclass instance which is used to generate an HttpResponse.
 	
 	"""
-	view_content_type = models.ForeignKey(ContentType, related_name='node_view_set', limit_choices_to=_view_content_type_limiter)
-	view_object_id = models.PositiveIntegerField()
+	view_content_type = models.ForeignKey(ContentType, related_name='node_view_set', limit_choices_to=_view_content_type_limiter, blank=True, null=True)
+	view_object_id = models.PositiveIntegerField(blank=True, null=True)
 	#: :class:`GenericForeignKey` to a non-abstract subclass of :class:`View`
 	view = generic.GenericForeignKey('view_content_type', 'view_object_id')
 	
 	@property
 	def accepts_subpath(self):
 		"""A property shortcut for :attr:`self.view.accepts_subpath <View.accepts_subpath>`"""
-		if self.view:
-			return self.view.accepts_subpath
+		if self.view_object_id and self.view_content_type_id:
+			return ContentType.objects.get_for_id(self.view_content_type_id).model_class().accepts_subpath
 		return False
 	
 	def handles_subpath(self, subpath):
-		return self.view.handles_subpath(subpath)
+		if self.view:
+			return self.view.handles_subpath(subpath)
+		return False
 	
 	def render_to_response(self, request, extra_context=None):
 		"""This is a shortcut method for :meth:`View.render_to_response`"""
-		return self.view.render_to_response(request, extra_context)
+		if self.view:
+			return self.view.render_to_response(request, extra_context)
+		raise Http404
 	
 	def get_absolute_url(self, request=None, with_domain=False, secure=False):
 		"""
@@ -104,7 +110,7 @@ class Node(TreeEntity):
 		
 		return '%s%s%s%s' % (domain, root_url, path, subpath)
 	
-	class Meta:
+	class Meta(SlugTreeEntity.Meta):
 		app_label = 'philo'
 
 
@@ -120,7 +126,7 @@ class View(Entity):
 	#: A generic relation back to nodes.
 	nodes = generic.GenericRelation(Node, content_type_field='view_content_type', object_id_field='view_object_id')
 	
-	#: Property or attribute which defines whether this :class:`View` can handle subpaths. Default: ``False``
+	#: An attribute on the class which defines whether this :class:`View` can handle subpaths. Default: ``False``
 	accepts_subpath = False
 	
 	def handles_subpath(self, subpath):
@@ -235,7 +241,7 @@ class MultiView(View):
 		
 		"""
 		clear_url_caches()
-		subpath = request.node.subpath
+		subpath = request.node._subpath
 		view, args, kwargs = resolve(subpath, urlconf=self)
 		view_args = getargspec(view)
 		if extra_context is not None and ('extra_context' in view_args[0] or view_args[2] is not None):
@@ -370,23 +376,32 @@ class Redirect(TargetURLModel, View):
 
 class File(View):
 	"""Stores an arbitrary file."""
-	#: Defines the mimetype of the uploaded file. This will not be validated.
-	mimetype = models.CharField(max_length=255)
+	#: The name of the uploaded file. This is meant for finding the file again later, not for display.
+	name = models.CharField(max_length=255)
+	#: Defines the mimetype of the uploaded file. This will not be validated. If no mimetype is provided, it will be automatically generated based on the filename.
+	mimetype = models.CharField(max_length=255, blank=True)
 	#: Contains the uploaded file. Files are uploaded to ``philo/files/%Y/%m/%d``.
 	file = models.FileField(upload_to='philo/files/%Y/%m/%d')
 	
+	def clean(self):
+		if not self.mimetype:
+			self.mimetype = mimetypes.guess_type(self.file.name, strict=False)[0]
+			if self.mimetype is None:
+				raise ValidationError("Unknown file type.")
+	
 	def actually_render_to_response(self, request, extra_context=None):
 		wrapper = FileWrapper(self.file)
 		response = HttpResponse(wrapper, content_type=self.mimetype)
 		response['Content-Length'] = self.file.size
+		response['Content-Disposition'] = "inline; filename=%s" % basename(self.file.name)
 		return response
 	
 	class Meta:
 		app_label = 'philo'
 	
 	def __unicode__(self):
-		"""Returns the path of the uploaded file."""
-		return self.file.name
+		"""Returns the value of :attr:`File.name`."""
+		return self.name
 
 
 register_value_model(Node)
\ No newline at end of file