X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/9cbb247dfb4faa47617438770bb6135155fade16..b97aa6632f51c6c1737768bde749dcd99bc5f1e6:/philo/models/nodes.py diff --git a/philo/models/nodes.py b/philo/models/nodes.py index 44a4d31..c29ac2a 100644 --- a/philo/models/nodes.py +++ b/philo/models/nodes.py @@ -14,8 +14,8 @@ from django.utils.encoding import smart_str from philo.exceptions import MIDDLEWARE_NOT_CONFIGURED, ViewCanNotProvideSubpath, ViewDoesNotProvideSubpaths from philo.models.base import TreeEntity, Entity, register_value_model from philo.models.fields import JSONField -from philo.utils import ContentTypeSubclassLimiter, LazyPassthroughAttributeMapper -from philo.validators import RedirectValidator +from philo.utils import ContentTypeSubclassLimiter +from philo.utils.entities import LazyPassthroughAttributeMapper from philo.signals import view_about_to_render, view_finished_rendering @@ -133,17 +133,14 @@ class View(Entity): If ``obj`` is provided, :meth:`get_reverse_params` will be called and the results will be combined with any ``view_name``, ``args``, and ``kwargs`` that may have been passed in. - This method will raise the following exceptions: - - - :class:`~philo.exceptions.ViewDoesNotProvideSubpaths` if :attr:`accepts_subpath` is False. - - :class:`~philo.exceptions.ViewCanNotProvideSubpath` if a reversal is not possible. - :param view_name: The name of the view to be reversed. :param args: Extra args for reversing the view. :param kwargs: A dictionary of arguments for reversing the view. :param node: The node whose subpath this is. :param obj: An object to be passed to :meth:`get_reverse_params` to generate a view_name, args, and kwargs for reversal. :returns: A subpath beyond the node that reverses the view, or an absolute url that reverses the view if a node was passed in. + :except philo.exceptions.ViewDoesNotProvideSubpaths: if :attr:`accepts_subpath` is False + :except philo.exceptions.ViewCanNotProvideSubpath: if a reversal is not possible. """ if not self.accepts_subpath: @@ -294,8 +291,8 @@ class TargetURLModel(models.Model): """An abstract parent class for models which deal in targeting a url.""" #: An optional :class:`ForeignKey` to a :class:`Node`. If provided, that node will be used as the basis for the redirect. target_node = models.ForeignKey(Node, blank=True, null=True, related_name="%(app_label)s_%(class)s_related") - #: A :class:`CharField` which may contain an absolute or relative URL. This will be validated with :class:`philo.validators.RedirectValidator`. - url_or_subpath = models.CharField(max_length=200, validators=[RedirectValidator()], blank=True, help_text="Point to this url or, if a node is defined and accepts subpaths, this subpath of the node.") + #: A :class:`CharField` which may contain an absolute or relative URL, or the name of a node's subpath. + url_or_subpath = models.CharField(max_length=200, blank=True, help_text="Point to this url or, if a node is defined and accepts subpaths, this subpath of the node.") #: A :class:`~philo.models.fields.JSONField` instance. If the value of :attr:`reversing_parameters` is not None, the :attr:`url_or_subpath` will be treated as the name of a view to be reversed. The value of :attr:`reversing_parameters` will be passed into the reversal as args if it is a list or as kwargs if it is a dictionary. Otherwise it will be ignored. reversing_parameters = JSONField(blank=True, help_text="If reversing parameters are defined, url_or_subpath will instead be interpreted as the view name to be reversed.")