X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/79e89d2c15b86b7b8d4ccf76c85d2fa2154cd2e8..7f6fa6595b4c558d7a97ed00cdb19469db4919df:/philo/models/nodes.py

diff --git a/philo/models/nodes.py b/philo/models/nodes.py
index 2d4639f..a225416 100644
--- a/philo/models/nodes.py
+++ b/philo/models/nodes.py
@@ -12,10 +12,9 @@ from django.template import add_to_builtins as register_templatetags
 from django.utils.encoding import smart_str
 
 from philo.exceptions import MIDDLEWARE_NOT_CONFIGURED, ViewCanNotProvideSubpath, ViewDoesNotProvideSubpaths
-from philo.models.base import TreeEntity, Entity, QuerySetMapper, register_value_model
+from philo.models.base import TreeEntity, Entity, register_value_model
 from philo.models.fields import JSONField
-from philo.utils import ContentTypeSubclassLimiter
-from philo.validators import RedirectValidator
+from philo.utils import ContentTypeSubclassLimiter, LazyPassthroughAttributeMapper
 from philo.signals import view_about_to_render, view_finished_rendering
 
 
@@ -133,17 +132,14 @@ class View(Entity):
 		
 		If ``obj`` is provided, :meth:`get_reverse_params` will be called and the results will be combined with any ``view_name``, ``args``, and ``kwargs`` that may have been passed in.
 		
-		This method will raise the following exceptions:
-		
-		- :class:`~philo.exceptions.ViewDoesNotProvideSubpaths` if :attr:`accepts_subpath` is False.
-		- :class:`~philo.exceptions.ViewCanNotProvideSubpath` if a reversal is not possible.
-		
 		:param view_name: The name of the view to be reversed.
 		:param args: Extra args for reversing the view.
 		:param kwargs: A dictionary of arguments for reversing the view.
 		:param node: The node whose subpath this is.
 		:param obj: An object to be passed to :meth:`get_reverse_params` to generate a view_name, args, and kwargs for reversal.
 		:returns: A subpath beyond the node that reverses the view, or an absolute url that reverses the view if a node was passed in.
+		:except philo.exceptions.ViewDoesNotProvideSubpaths: if :attr:`accepts_subpath` is False
+		:except philo.exceptions.ViewCanNotProvideSubpath: if a reversal is not possible.
 		
 		"""
 		if not self.accepts_subpath:
@@ -176,10 +172,10 @@ class View(Entity):
 	
 	def attributes_with_node(self, node):
 		"""
-		Returns a :class:`~philo.models.base.QuerySetMapper` using the :class:`Node`'s attributes as a passthrough.
+		Returns a dictionary-like object which can be used to directly retrieve the values of :class:`Attribute`\ s related to the :class:`View`, falling back on similar object which retrieves the values of the passed-in node and its ancestors.
 		
 		"""
-		return QuerySetMapper(self.attribute_set, passthrough=node.attributes)
+		return LazyPassthroughAttributeMapper((self, node))
 	
 	def render_to_response(self, request, extra_context=None):
 		"""
@@ -294,8 +290,8 @@ class TargetURLModel(models.Model):
 	"""An abstract parent class for models which deal in targeting a url."""
 	#: An optional :class:`ForeignKey` to a :class:`Node`. If provided, that node will be used as the basis for the redirect.
 	target_node = models.ForeignKey(Node, blank=True, null=True, related_name="%(app_label)s_%(class)s_related")
-	#: A :class:`CharField` which may contain an absolute or relative URL. This will be validated with :class:`philo.validators.RedirectValidator`.
-	url_or_subpath = models.CharField(max_length=200, validators=[RedirectValidator()], blank=True, help_text="Point to this url or, if a node is defined and accepts subpaths, this subpath of the node.")
+	#: A :class:`CharField` which may contain an absolute or relative URL, or the name of a node's subpath.
+	url_or_subpath = models.CharField(max_length=200, blank=True, help_text="Point to this url or, if a node is defined and accepts subpaths, this subpath of the node.")
 	#: A :class:`~philo.models.fields.JSONField` instance. If the value of :attr:`reversing_parameters` is not None, the :attr:`url_or_subpath` will be treated as the name of a view to be reversed. The value of :attr:`reversing_parameters` will be passed into the reversal as args if it is a list or as kwargs if it is a dictionary. Otherwise it will be ignored.
 	reversing_parameters = JSONField(blank=True, help_text="If reversing parameters are defined, url_or_subpath will instead be interpreted as the view name to be reversed.")