X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/786854beaf0a823da2bbbf6696bcd53478e3c059..a05c936dabd92bf4756f4ca2c23ef0320b0543d9:/philo/models/nodes.py?ds=inline

diff --git a/philo/models/nodes.py b/philo/models/nodes.py
index 93f772a..830f94a 100644
--- a/philo/models/nodes.py
+++ b/philo/models/nodes.py
@@ -31,24 +31,30 @@ class Node(SlugTreeEntity):
 	:class:`Node`\ s are the basic building blocks of a website using Philo. They define the URL hierarchy and connect each URL to a :class:`View` subclass instance which is used to generate an HttpResponse.
 	
 	"""
-	view_content_type = models.ForeignKey(ContentType, related_name='node_view_set', limit_choices_to=_view_content_type_limiter)
-	view_object_id = models.PositiveIntegerField()
+	view_content_type = models.ForeignKey(ContentType, related_name='node_view_set', limit_choices_to=_view_content_type_limiter, blank=True, null=True)
+	view_object_id = models.PositiveIntegerField(blank=True, null=True)
 	#: :class:`GenericForeignKey` to a non-abstract subclass of :class:`View`
 	view = generic.GenericForeignKey('view_content_type', 'view_object_id')
 	
 	@property
 	def accepts_subpath(self):
 		"""A property shortcut for :attr:`self.view.accepts_subpath <View.accepts_subpath>`"""
-		if self.view:
-			return self.view.accepts_subpath
+		if self.view_object_id and self.view_content_type_id:
+			return ContentType.objects.get_for_id(self.view_content_type_id).model_class().accepts_subpath
 		return False
 	
 	def handles_subpath(self, subpath):
-		return self.view.handles_subpath(subpath)
+		if self.view_object_id and self.view_content_type_id:
+			return ContentType.objects.get_for_id(self.view_content_type_id).model_class().handles_subpath(subpath)
+		return False
 	
 	def render_to_response(self, request, extra_context=None):
 		"""This is a shortcut method for :meth:`View.render_to_response`"""
-		return self.view.render_to_response(request, extra_context)
+		if self.view_object_id and self.view_content_type_id:
+			view_model = ContentType.objects.get_for_id(self.view_content_type_id).model_class()
+			self.view = view_model._default_manager.select_related(depth=1).get(pk=self.view_object_id)
+			return self.view.render_to_response(request, extra_context)
+		raise Http404
 	
 	def get_absolute_url(self, request=None, with_domain=False, secure=False):
 		"""
@@ -122,12 +128,13 @@ class View(Entity):
 	#: A generic relation back to nodes.
 	nodes = generic.GenericRelation(Node, content_type_field='view_content_type', object_id_field='view_object_id')
 	
-	#: Property or attribute which defines whether this :class:`View` can handle subpaths. Default: ``False``
+	#: An attribute on the class which defines whether this :class:`View` can handle subpaths. Default: ``False``
 	accepts_subpath = False
 	
-	def handles_subpath(self, subpath):
+	@classmethod
+	def handles_subpath(cls, subpath):
 		"""Returns True if the :class:`View` handles the given subpath, and False otherwise."""
-		if not self.accepts_subpath and subpath != "/":
+		if not cls.accepts_subpath and subpath != "/":
 			return False
 		return True
 	
@@ -222,15 +229,6 @@ class MultiView(View):
 		"""Returns urlpatterns that point to views (generally methods on the class). :class:`MultiView`\ s can be thought of as "managing" these subpaths."""
 		raise NotImplementedError("MultiView subclasses must implement urlpatterns.")
 	
-	def handles_subpath(self, subpath):
-		if not super(MultiView, self).handles_subpath(subpath):
-			return False
-		try:
-			resolve(subpath, urlconf=self)
-		except Http404:
-			return False
-		return True
-	
 	def actually_render_to_response(self, request, extra_context=None):
 		"""
 		Resolves the remaining subpath left after finding this :class:`View`'s node using :attr:`self.urlpatterns <urlpatterns>` and renders the view function (or method) found with the appropriate args and kwargs.