X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/344bace6dc955286a59480e8bf538ab524a7ee9f..7f6fa6595b4c558d7a97ed00cdb19469db4919df:/philo/models/nodes.py diff --git a/philo/models/nodes.py b/philo/models/nodes.py index 899303f..a225416 100644 --- a/philo/models/nodes.py +++ b/philo/models/nodes.py @@ -12,10 +12,9 @@ from django.template import add_to_builtins as register_templatetags from django.utils.encoding import smart_str from philo.exceptions import MIDDLEWARE_NOT_CONFIGURED, ViewCanNotProvideSubpath, ViewDoesNotProvideSubpaths -from philo.models.base import TreeEntity, Entity, QuerySetMapper, register_value_model +from philo.models.base import TreeEntity, Entity, register_value_model from philo.models.fields import JSONField -from philo.utils import ContentTypeSubclassLimiter -from philo.validators import RedirectValidator +from philo.utils import ContentTypeSubclassLimiter, LazyPassthroughAttributeMapper from philo.signals import view_about_to_render, view_finished_rendering @@ -173,10 +172,10 @@ class View(Entity): def attributes_with_node(self, node): """ - Returns a :class:`~philo.models.base.QuerySetMapper` using the :class:`Node`'s attributes as a passthrough. + Returns a dictionary-like object which can be used to directly retrieve the values of :class:`Attribute`\ s related to the :class:`View`, falling back on similar object which retrieves the values of the passed-in node and its ancestors. """ - return QuerySetMapper(self.attribute_set, passthrough=node.attributes) + return LazyPassthroughAttributeMapper((self, node)) def render_to_response(self, request, extra_context=None): """ @@ -291,8 +290,8 @@ class TargetURLModel(models.Model): """An abstract parent class for models which deal in targeting a url.""" #: An optional :class:`ForeignKey` to a :class:`Node`. If provided, that node will be used as the basis for the redirect. target_node = models.ForeignKey(Node, blank=True, null=True, related_name="%(app_label)s_%(class)s_related") - #: A :class:`CharField` which may contain an absolute or relative URL. This will be validated with :class:`philo.validators.RedirectValidator`. - url_or_subpath = models.CharField(max_length=200, validators=[RedirectValidator()], blank=True, help_text="Point to this url or, if a node is defined and accepts subpaths, this subpath of the node.") + #: A :class:`CharField` which may contain an absolute or relative URL, or the name of a node's subpath. + url_or_subpath = models.CharField(max_length=200, blank=True, help_text="Point to this url or, if a node is defined and accepts subpaths, this subpath of the node.") #: A :class:`~philo.models.fields.JSONField` instance. If the value of :attr:`reversing_parameters` is not None, the :attr:`url_or_subpath` will be treated as the name of a view to be reversed. The value of :attr:`reversing_parameters` will be passed into the reversal as args if it is a list or as kwargs if it is a dictionary. Otherwise it will be ignored. reversing_parameters = JSONField(blank=True, help_text="If reversing parameters are defined, url_or_subpath will instead be interpreted as the view name to be reversed.")