X-Git-Url: http://git.ithinksw.org/philo.git/blobdiff_plain/0252668f3fd56d3837eb0372f53deb4a7a657ff7..2c572cb884ee8c75d4f730cce43c9905bd590d33:/philo/contrib/shipherd/models.py?ds=sidebyside

diff --git a/philo/contrib/shipherd/models.py b/philo/contrib/shipherd/models.py
index 934af2a..95be501 100644
--- a/philo/contrib/shipherd/models.py
+++ b/philo/contrib/shipherd/models.py
@@ -27,13 +27,12 @@ class NavigationMapper(object, DictMixin):
 		self._cache = {}
 	
 	def __getitem__(self, key):
-		return Navigation.objects.get_for_node(self.node, key)
-		#if key not in self._cache:
-		#	try:
-		#		self._cache[key] = Navigation.objects.get_for_node(self.node, key)
-		#	except Navigation.DoesNotExist:
-		#		self._cache[key] = None
-		#return self._cache[key]
+		if key not in self._cache:
+			try:
+				self._cache[key] = Navigation.objects.get_for_node(self.node, key)
+			except Navigation.DoesNotExist:
+				self._cache[key] = None
+		return self._cache[key]
 
 
 def navigation(self):
@@ -64,7 +63,7 @@ class NavigationManager(models.Manager):
 			}
 			navs = self.filter(key=key, **kwargs).select_related('node').order_by('-node__%s' % opts.level_attr)
 			nav = navs[0]
-			roots = nav.roots.all().select_related('target_node')
+			roots = nav.roots.all().select_related('target_node').order_by('order')
 			item_opts = NavigationItem._mptt_meta
 			by_pk = {}
 			tree_ids = []
@@ -75,7 +74,9 @@ class NavigationManager(models.Manager):
 				by_pk[root.pk] = root
 				tree_ids.append(getattr(root, item_opts.tree_id_attr))
 				root._cached_children = []
-				root.target_node.get_path(root=site_root_node)
+				if root.target_node:
+					root.target_node.get_path(root=site_root_node)
+				root.navigation = nav
 			
 			kwargs = {
 				'%s__in' % item_opts.tree_id_attr: tree_ids,
@@ -89,7 +90,8 @@ class NavigationManager(models.Manager):
 				parent_pk = getattr(item, '%s_id' % item_opts.parent_attr)
 				item.parent = by_pk[parent_pk]
 				item.parent._cached_children.append(item)
-				item.target_node.get_path(root=site_root_node)
+				if item.target_node:
+					item.target_node.get_path(root=site_root_node)
 			
 			cached = roots
 			cache.set(cache_key, cached)
@@ -172,13 +174,15 @@ class NavigationItem(TreeEntity, TargetURLModel):
 			# the same as the request path, check whether the target node is an ancestor
 			# of the requested node. If so, this is active unless the target node
 			# is the same as the ``host node`` for this navigation structure.
-			try:
-				host_node = self.get_root().navigation.node
-			except AttributeError:
-				pass
-			else:
-				if self.target_node != host_node and self.target_node.is_ancestor_of(request.node):
-					return True
+			root = self
+			
+			# The common case will be cached items, whose parents are cached with them.
+			while root.parent is not None:
+				root = root.parent
+			
+			host_node_id = root.navigation.node_id
+			if self.target_node.pk != host_node_id and self.target_node.is_ancestor_of(request.node):
+				return True
 		
 		return False