Increased specificity of penfield get_article conditions for 404 raising. Corrected...

[philo.git] / contrib / penfield / models.py

diff --git a/contrib/penfield/models.py b/contrib/penfield/models.py
index 6da87a6..8248340 100644 (file)
--- a/contrib/penfield/models.py
+++ b/contrib/penfield/models.py
@@ -387,7 +387,7 @@ class NewsletterView(MultiView, FeedMultiViewMixin):
        def get_articles_by_issue(self, request, numbering, extra_context=None):
                try:
                        issue = self.newsletter.issues.get(numbering=numbering)
        def get_articles_by_issue(self, request, numbering, extra_context=None):
                try:
                        issue = self.newsletter.issues.get(numbering=numbering)

-               except:
+               except NewsletterIssue.DoesNotExist:

                        raise Http404
                context = extra_context or {}
                context.update({'issue': issue})
                        raise Http404
                context = extra_context or {}
                context.update({'issue': issue})


@@ -403,7 +403,7 @@ class NewsletterView(MultiView, FeedMultiViewMixin):
                        articles = articles.filter(date__day=day)
                try:
                        article = articles.get(slug=slug)
                        articles = articles.filter(date__day=day)
                try:
                        article = articles.get(slug=slug)

-               except:
+               except NewsletterArticle.DoesNotExist:

                        raise Http404
                context = self.get_context()
                context.update(extra_context or {})
                        raise Http404
                context = self.get_context()
                context.update(extra_context or {})


@@ -421,7 +421,7 @@ class NewsletterView(MultiView, FeedMultiViewMixin):
        def add_item(self, feed, obj, kwargs=None):
                defaults = {
                        'title': obj.title,
        def add_item(self, feed, obj, kwargs=None):
                defaults = {
                        'title': obj.title,

-                       'author_name': ', '.join(obj.authors),
+                       'author_name': ', '.join([author.get_full_name() for author in obj.authors.all()]),

                        'pubdate': obj.date,
                        'description': obj.lede or obj.full_text,
                        'categories': [tag.name for tag in obj.tags.all()]
                        'pubdate': obj.date,
                        'description': obj.lede or obj.full_text,
                        'categories': [tag.name for tag in obj.tags.all()]