From: Matthew Judy <mjudy@ithinksw.com>
Date: Fri, 11 Apr 2003 13:03:07 +0000 (+0000)
Subject: Prefs tweaks, and to-do's.
X-Git-Tag: v1.0~141
X-Git-Url: http://git.ithinksw.org/MenuTunes.git/commitdiff_plain/d874a259ba070bb282b894ebe6473eceef757822

Prefs tweaks, and to-do's.
---

diff --git a/English.lproj/Preferences.nib/keyedobjects.nib b/English.lproj/Preferences.nib/keyedobjects.nib
index bb273f6..132186b 100755
Binary files a/English.lproj/Preferences.nib/keyedobjects.nib and b/English.lproj/Preferences.nib/keyedobjects.nib differ
diff --git a/PreferencesController.m b/PreferencesController.m
index ba70e0d..c230e13 100755
--- a/PreferencesController.m
+++ b/PreferencesController.m
@@ -94,25 +94,42 @@ static PreferencesController *prefs = nil;
 
 - (IBAction)changeGeneralSetting:(id)sender
 {
+    BOOL rebuildRequired = NO;
+
     if ( [sender tag] == 1010) {
         [self setLaunchesAtLogin:SENDER_STATE];
     } else if ( [sender tag] == 1020) {
         [df setBool:SENDER_STATE forKey:@"LaunchPlayerWithMT"];
     } else if ( [sender tag] == 1030) {
         [df setInteger:[sender intValue] forKey:@"SongsInAdvance"];
+        rebuildRequired = YES;
     } else if ( [sender tag] == 1040) {
-        [df setBool:SENDER_STATE forKey:@"showAlbum"];
+        // This will not be executed.  Song info always shows the title of the song.
+        // [df setBool:SENDER_STATE forKey:@"showName"];
+        // rebuildRequired = YES;
     } else if ( [sender tag] == 1050) {
-        [df setBool:SENDER_STATE forKey:@"showName"];
-    } else if ( [sender tag] == 1060) {
         [df setBool:SENDER_STATE forKey:@"showArtist"];
+        rebuildRequired = YES;
+    } else if ( [sender tag] == 1060) {
+        [df setBool:SENDER_STATE forKey:@"showAlbum"];
+        rebuildRequired = YES;
     } else if ( [sender tag] == 1070) {
         [df setBool:SENDER_STATE forKey:@"showTime"];
+        rebuildRequired = YES;
     } else if ( [sender tag] == 1080) {
         [df setBool:SENDER_STATE forKey:@"showTrackNumber"];
+        rebuildRequired = YES;
     } else if ( [sender tag] == 1090) {
         [df setBool:SENDER_STATE forKey:@"showTrackRating"];
+        rebuildRequired = YES;
     }
+
+    if ( rebuildRequired ) {
+        [controller rebuildMenu];
+        // redraw song info status window, or upcoming songs here
+    }
+
+    [df synchronize];
 }
 
 - (IBAction)changeStatusWindowSetting:(id)sender
@@ -216,7 +233,7 @@ static PreferencesController *prefs = nil;
         nil] forKey:@"menu"];
 
     [df setInteger:5 forKey:@"SongsInAdvance"];
-    [df setBool:YES forKey:@"showName"];
+    // [df setBool:YES forKey:@"showName"];  // Song info will always show song title.
     [df setBool:YES forKey:@"showArtist"];
     [df setBool:NO forKey:@"showAlbum"];
     [df setBool:NO forKey:@"showTime"];
@@ -651,7 +668,8 @@ static PreferencesController *prefs = nil;
     
     // Check current track info buttons
     [albumCheckbox setState:[df boolForKey:@"showAlbum"] ? NSOnState : NSOffState];
-    [nameCheckbox setState:[df boolForKey:@"showName"] ? NSOnState : NSOffState];
+    [nameCheckbox setState:NSOnState];  // Song info will ALWAYS show song title.
+    [nameCheckbox setEnabled:NO];  // Song info will ALWAYS show song title.
     [artistCheckbox setState:[df boolForKey:@"showArtist"] ? NSOnState : NSOffState];
     [trackTimeCheckbox setState:[df boolForKey:@"showTime"] ? NSOnState : NSOffState];
     
diff --git a/TODO.rtf b/TODO.rtf
index 9ea398f..04da3e2 100755
--- a/TODO.rtf
+++ b/TODO.rtf
@@ -13,6 +13,10 @@
 \pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\ql\qnatural
 
 \f3\b0\fs20 \cf0 \ulnone \
+    Priority: SHOWSTOPPER\
+      Status: Analyze\
+       Issue: Menu - Rebuild speed is abyssmal.  It needs to take less than half a second.\
+\
     Priority: SHOWSTOPPER\
       Status: Analyze\
        Issue: HotKeys - FKeys must be made to work without a modifier key.\
@@ -52,6 +56,10 @@
     Priority: SHOWSTOPPER\
       Status: Assigned\
        Issue: Registration - Add in eSellerate validation, and nag reminder.\
+\
+    Priority: SHOWSTOPPER\
+      Status: Assigned\
+       Issue: Menu - Shows "No Song" when one is playing. (if not in a playlist?)\
 \
 \
 \pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\ql\qnatural
@@ -76,4 +84,10 @@ No entries yet.\
        Issue: Upcoming Songs - should be clickable.\
 \pard\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\li720\ql\qnatural
 \cf0 \
+\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\ql\qnatural
+\cf0     Priority: FUTURE\
+      Status: Future\
+       Issue: Upcoming Songs - should show the last <preference> songs played.\
+\pard\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\li720\ql\qnatural
+\cf0 \
 }
\ No newline at end of file