From: Alexander Strange Date: Sat, 22 Feb 2003 05:27:14 +0000 (+0000) Subject: Fixing two memory leaks and some inefficiency in iTunesRemote X-Git-Tag: v1.0~230 X-Git-Url: http://git.ithinksw.org/MenuTunes.git/commitdiff_plain/2ecc77b9a1880b6dd341c445aa6509b6acd6d633 Fixing two memory leaks and some inefficiency in iTunesRemote --- diff --git a/iTunesRemote.m b/iTunesRemote.m index 5bab47e..23e6094 100755 --- a/iTunesRemote.m +++ b/iTunesRemote.m @@ -52,9 +52,9 @@ - (BOOL)isAppRunning { NSArray *apps = [[NSWorkspace sharedWorkspace] launchedApplications]; - int i; + int i,count = [apps count]; - for (i = 0; i < [apps count]; i++) { + for (i = 0; i < count; i++) { if ([[[apps objectAtIndex:i] objectForKey:@"NSApplicationName"] isEqualToString:@"iTunes"]) { return YES; @@ -91,7 +91,7 @@ [presets addObject:[self runScriptAndReturnResult:[NSString stringWithFormat:@"get name of playlist %i", i]]]; } - return [NSArray arrayWithArray:presets]; + return [presets autorelease]; } - (int)numberOfSongsInPlaylistAtIndex:(int)index @@ -197,7 +197,7 @@ [presets addObject:[self runScriptAndReturnResult:[NSString stringWithFormat:@"get name of EQ preset %i", i]]]; } - return [NSArray arrayWithArray:presets]; + return [presets autorelease]; } - (int)currentEQPresetIndex