X-Git-Url: http://git.ithinksw.org/MenuTunes.git/blobdiff_plain/bf725eadb3fd7b6a74b4043ef17366fce403dff7..247185755806e3a693fef80a25094ad9e446f104:/MainController.m

diff --git a/MainController.m b/MainController.m
index 14bfb59..20f4381 100755
--- a/MainController.m
+++ b/MainController.m
@@ -479,11 +479,12 @@ static MainController *sharedController;
 			
 			if ([df boolForKey:@"audioscrobblerEnabled"]) {
 				int length = [[self currentRemote] currentSongDuration];
-				if (_audioscrobblerTimer) {
-					[_audioscrobblerTimer invalidate];
-				}
 				if (length > 30) {
-					_audioscrobblerTimer = [NSTimer scheduledTimerWithTimeInterval:((length / 2 < 240) ? length / 2 : 240) target:self selector:@selector(submitAudioscrobblerTrack:) userInfo:nil repeats:YES];
+					_audioscrobblerInterval = ((length / 2 < 240) ? length / 2 : 240);
+					[_audioscrobblerTimer invalidate];
+					[_audioscrobblerTimer release];
+					_audioscrobblerTimer = [[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSinceNow:_audioscrobblerInterval] interval:nil target:self selector:@selector(submitAudioscrobblerTrack:) userInfo:nil repeats:NO];
+					[[NSRunLoop currentRunLoop] addTimer:_audioscrobblerTimer forMode:NSDefaultRunLoopMode];
 				}
 			} else {
 				_audioscrobblerTimer = nil;
@@ -605,11 +606,12 @@ static MainController *sharedController;
 		
 		if ([df boolForKey:@"audioscrobblerEnabled"]) {
 			int length = [[self currentRemote] currentSongDuration];
-			if (_audioscrobblerTimer) {
-				[_audioscrobblerTimer invalidate];
-			}
 			if (length > 30) {
-				_audioscrobblerTimer = [NSTimer scheduledTimerWithTimeInterval:((length / 2 < 240) ? length / 2 : 240) target:self selector:@selector(submitAudioscrobblerTrack:) userInfo:nil repeats:YES];
+				_audioscrobblerInterval = ((length / 2 < 240) ? length / 2 : 240);
+				[_audioscrobblerTimer invalidate];
+				[_audioscrobblerTimer release];
+				_audioscrobblerTimer = [[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSinceNow:_audioscrobblerInterval] interval:1.0 target:self selector:@selector(submitAudioscrobblerTrack:) userInfo:nil repeats:NO];
+				[[NSRunLoop currentRunLoop] addTimer:_audioscrobblerTimer forMode:NSDefaultRunLoopMode];
 			}
 		} else {
 			_audioscrobblerTimer = nil;
@@ -627,15 +629,14 @@ static MainController *sharedController;
 
 - (void)submitAudioscrobblerTrack:(NSTimer *)timer
 {
-	int interval = [timer timeInterval];
-	[timer invalidate];
-	_audioscrobblerTimer = nil;
 	ITDebugLog(@"Audioscrobbler: Attempting to submit current track");
+	[timer invalidate];
 	if ([df boolForKey:@"audioscrobblerEnabled"]) {
 		NS_DURING
-			int elapsed = [[self currentRemote] currentSongPlayed];
-			if ((abs(elapsed - interval) < 5) && ([[self currentRemote] playerPlayingState] == ITMTRemotePlayerPlaying)) {
+			int elapsed = [[self currentRemote] currentSongPlayed], length = [[self currentRemote] currentSongDuration], requiredInterval = ((length / 2 < 240) ? length / 2 : 240);
+			if ((abs(elapsed - requiredInterval) < 5) && ([[self currentRemote] playerPlayingState] == ITMTRemotePlayerPlaying)) {
 				NSString *title = [[self currentRemote] currentSongTitle], *artist = [[self currentRemote] currentSongArtist];
+				NSLog(@"Audioscrobbler: Submitting");
 				if (title && artist) {
 					ITDebugLog(@"Audioscrobbler: Submitting current track");
 					[[AudioscrobblerController sharedController] submitTrack:title
@@ -643,9 +644,15 @@ static MainController *sharedController;
 																	album:[[self currentRemote] currentSongAlbum]
 																	length:[[self currentRemote] currentSongDuration]];
 				}
-			} else if (interval - elapsed > 0) {
-				ITDebugLog(@"Audioscrobbler: Creating a new timer that will run in %i seconds", interval - elapsed);
-				_audioscrobblerTimer = [NSTimer scheduledTimerWithTimeInterval:(interval - elapsed) target:self selector:@selector(submitAudioscrobblerTrack:) userInfo:nil repeats:YES];
+			} else if (requiredInterval - elapsed > 0) {
+				_audioscrobblerInterval = requiredInterval - elapsed;
+				[_audioscrobblerTimer release];
+				NSLog(@"Audioscrobbler: Creating a new timer that will run in %i seconds", _audioscrobblerInterval);
+				ITDebugLog(@"Audioscrobbler: Creating a new timer that will run in %i seconds", _audioscrobblerInterval);
+				_audioscrobblerTimer = [[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSinceNow:_audioscrobblerInterval] interval:1.0 target:self selector:@selector(submitAudioscrobblerTrack:) userInfo:nil repeats:NO];
+				[[NSRunLoop currentRunLoop] addTimer:_audioscrobblerTimer forMode:NSDefaultRunLoopMode];
+			} else {
+				NSLog(@"Audioscrobbler: Skipping submission. %i, %i", requiredInterval, elapsed);
 			}
 		NS_HANDLER
 			[self networkError:localException];