X-Git-Url: http://git.ithinksw.org/MenuTunes.git/blobdiff_plain/259ae5fac769954c7db5974b86e791a929fe6700..4909f1dfc7aca6fc2d2cfa0ad60897df44f4affe:/PreferencesController.m

diff --git a/PreferencesController.m b/PreferencesController.m
index 6f8abfd..2b1bbf8 100755
--- a/PreferencesController.m
+++ b/PreferencesController.m
@@ -16,25 +16,11 @@
 #import <sys/types.h>
 #import <sys/stat.h>
 
-#import <ITKit/ITLoginItem.h>
-
-#import <ITKit/ITHotKeyCenter.h>
-#import <ITKit/ITKeyCombo.h>
-#import <ITKit/ITKeyComboPanel.h>
-#import <ITKit/ITWindowPositioning.h>
-#import <ITKit/ITKeyBroadcaster.h>
-
+#import <ITKit/ITKit.h>
 #import <ITKit/ITTSWBackgroundView.h>
-#import <ITKit/ITWindowEffect.h>
-#import <ITKit/ITCutWindowEffect.h>
-#import <ITKit/ITDissolveWindowEffect.h>
-#import <ITKit/ITSlideHorizontallyWindowEffect.h>
-#import <ITKit/ITSlideVerticallyWindowEffect.h>
-#import <ITKit/ITPivotWindowEffect.h>
-
 
 #define SENDER_STATE (([sender state] == NSOnState) ? YES : NO)
-#define AUDIOSCROBBLER_KEYCHAIN_SERVICE "MenuTunes: Audioscrobbler"
+#define AUDIOSCROBBLER_KEYCHAIN_SERVICE(user) [[NSString stringWithFormat:@"Audioscrobbler: %@", user] UTF8String]
 #define AUDIOSCROBBLER_KEYCHAIN_KIND "application password"
 
 /*************************************************************************/
@@ -86,6 +72,10 @@ static PreferencesController *prefs = nil;
 	SecKeychainAttribute attributes[3];
 	SecKeychainAttributeList list;
 
+	if ((user == nil) || ([user length] == 0)) {
+		return nil;
+	}
+
 	ITDebugLog(@"Audioscrobbler: Searching for keychain item for %@.", user);
 	attributes[0].tag = kSecAccountItemAttr;
 	attributes[0].data = (char *)[user UTF8String];
@@ -94,8 +84,8 @@ static PreferencesController *prefs = nil;
 	attributes[1].data = AUDIOSCROBBLER_KEYCHAIN_KIND;
 	attributes[1].length = strlen(AUDIOSCROBBLER_KEYCHAIN_KIND);
 	attributes[2].tag = kSecLabelItemAttr;
-	attributes[2].data = AUDIOSCROBBLER_KEYCHAIN_SERVICE;
-	attributes[2].length = strlen(AUDIOSCROBBLER_KEYCHAIN_SERVICE);
+	attributes[2].data = (char *)AUDIOSCROBBLER_KEYCHAIN_SERVICE(user);
+	attributes[2].length = strlen(AUDIOSCROBBLER_KEYCHAIN_SERVICE(user));
 	list.count = 3;
 	list.attr = attributes;
 
@@ -141,8 +131,8 @@ static PreferencesController *prefs = nil;
 	attributes[1].data = AUDIOSCROBBLER_KEYCHAIN_KIND;
 	attributes[1].length = strlen(AUDIOSCROBBLER_KEYCHAIN_KIND);
 	attributes[2].tag = kSecLabelItemAttr;
-	attributes[2].data = AUDIOSCROBBLER_KEYCHAIN_SERVICE;
-	attributes[2].length = strlen(AUDIOSCROBBLER_KEYCHAIN_SERVICE);
+	attributes[2].data = (char *)AUDIOSCROBBLER_KEYCHAIN_SERVICE(user);
+	attributes[2].length = strlen(AUDIOSCROBBLER_KEYCHAIN_SERVICE(user));
 	list.count = 3;
 	list.attr = attributes;
 
@@ -172,7 +162,7 @@ static PreferencesController *prefs = nil;
 	OSStatus status = errSecNotAvailable;
 	SecKeychainItemRef item = [PreferencesController keychainItemForUser:user];
 	if (item != nil) {
-		status = SecKeychainItemModifyContent(item, NULL, [password length], [password cString]);
+		status = SecKeychainItemModifyContent(item, NULL, [password length], [password UTF8String]);
 		if (status != noErr) {
 			ITDebugLog(@"Audioscrobbler: Error deleting keychain item: %i", status);
 		}
@@ -193,18 +183,15 @@ static PreferencesController *prefs = nil;
 		if (status != noErr) {
 			ITDebugLog(@"Audioscrobbler: Error getting keychain item password: %i", status);
 		} else {
-			if ([NSString respondsToSelector:@selector(stringWithCString:encoding:)]) {
-				pass = [NSString stringWithCString:buffer encoding:NSASCIIStringEncoding];
-			} else {
-				pass = [NSString stringWithCString:buffer];
-			}
+			pass = [[NSString alloc] initWithBytes:buffer length:length encoding:NSUTF8StringEncoding];
 		}
 		if (status != noErr) {
 			ITDebugLog(@"Audioscrobbler: Error deleting keychain item: %i", status);
 		}
+		SecKeychainItemFreeContent(NULL, buffer);
 		CFRelease(item);
 	}
-	return pass;
+	return [pass autorelease];
 }
 
 /*************************************************************************/
@@ -235,6 +222,7 @@ static PreferencesController *prefs = nil;
                                                        @"Rewind",
                                                        @"ShowPlayer",
                                                        @"TrackInfo",
+													   @"AlbumArt",
                                                        @"UpcomingSongs",
                                                        @"IncrementVolume",
                                                        @"DecrementVolume",
@@ -259,6 +247,7 @@ static PreferencesController *prefs = nil;
                                                        @"Rewind",
                                                        @"Show Player",
                                                        @"Track Info",
+													   @"Album Art",
                                                        @"Upcoming Songs",
                                                        @"Increment Volume",
                                                        @"Decrement Volume",
@@ -273,7 +262,7 @@ static PreferencesController *prefs = nil;
                                                        [NSString stringWithUTF8String:"Set Rating: ★★☆☆☆"],
                                                        [NSString stringWithUTF8String:"Set Rating: ★★★☆☆"],
                                                        [NSString stringWithUTF8String:"Set Rating: ★★★★☆"],
-                                                       [NSString stringWithUTF8String:"Set Rating: ★★★★★"],
+                                                       [NSString stringWithUTF8String:"Set Rating: ★★★★"],
                                                        nil];
         hotKeysDictionary = [[NSMutableDictionary alloc] init];
         controller = nil;
@@ -414,7 +403,7 @@ static PreferencesController *prefs = nil;
             [showScriptsButton setEnabled:NO];
         }
     } else if ( [sender tag] == 1120) {
-        mkdir([[NSHomeDirectory() stringByAppendingPathComponent:@"Library/Application Support/MenuTunes/Scripts"] cString], 0744);
+        mkdir([[NSHomeDirectory() stringByAppendingPathComponent:@"Library/Application Support/MenuTunes/Scripts"] UTF8String], 0744);
         [[NSWorkspace sharedWorkspace] openFile:[NSHomeDirectory() stringByAppendingPathComponent:@"Library/Application Support/MenuTunes/Scripts"]];
     } else if ( [sender tag] == 6010) {
 		//Toggle the other Audioscrobbler options
@@ -422,6 +411,9 @@ static PreferencesController *prefs = nil;
 		[audioscrobblerUseCacheCheckbox setEnabled:SENDER_STATE];
 		[audioscrobblerUserTextField setEnabled:SENDER_STATE];
 		[audioscrobblerPasswordTextField setEnabled:SENDER_STATE];
+		if (SENDER_STATE) {
+			[[AudioscrobblerController sharedController] attemptHandshake:NO];
+		}
 	} else if ( [sender tag ] == 6015) {
 		//Here we create a new keychain item if needed and deletes the keychain item if the field is cleared.
 		NSString *currentAccount = [df stringForKey:@"audioscrobblerUser"], *newAccount = [sender stringValue];
@@ -603,7 +595,7 @@ static PreferencesController *prefs = nil;
 
 - (IBAction)changeStatusWindowSetting:(id)sender
 {
-    StatusWindow *sw = [StatusWindow sharedWindow];
+    StatusWindow *sw = (StatusWindow *)[StatusWindow sharedWindow];
     ITDebugLog(@"Changing status window setting of tag %i", [sender tag]);
     
     if ( [sender tag] == 2010) {
@@ -886,6 +878,11 @@ static PreferencesController *prefs = nil;
 #pragma mark PRIVATE METHOD IMPLEMENTATIONS
 /*************************************************************************/
 
+- (void)audioscrobblerStatusChanged:(NSNotification *)note
+{
+	[audioscrobblerStatusTextField setStringValue:[[note userInfo] objectForKey:@"StatusString"]];
+}
+
 - (void)setupWindow
 {
     ITDebugLog(@"Loading Preferences.nib.");
@@ -971,6 +968,12 @@ static PreferencesController *prefs = nil;
     int selectedBGStyle;
     id anItem;
 	
+	[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(audioscrobblerStatusChanged:) name:@"AudioscrobblerStatusChanged" object:nil];
+	if ([df boolForKey:@"audioscrobblerEnabled"]) {
+		NSString *status = [[AudioscrobblerController sharedController] lastStatus];
+		[audioscrobblerStatusTextField setStringValue:(status == nil) ? @"Idle" : status];
+	}
+	
     [df setInteger:MT_CURRENT_VERSION forKey:@"appVersion"];
     
     ITDebugLog(@"Setting up preferences UI.");
@@ -1162,7 +1165,7 @@ static PreferencesController *prefs = nil;
 
 - (void)setStatusWindowEntryEffect:(Class)effectClass
 {
-    StatusWindow *sw = [StatusWindow sharedWindow];
+    StatusWindow *sw = (StatusWindow *)[StatusWindow sharedWindow];
     
     float time = ([df floatForKey:@"statusWindowAppearanceSpeed"] ? [df floatForKey:@"statusWindowAppearanceSpeed"] : 0.8);
     [df setObject:NSStringFromClass(effectClass) forKey:@"statusWindowAppearanceEffect"];
@@ -1173,7 +1176,7 @@ static PreferencesController *prefs = nil;
 
 - (void)setStatusWindowExitEffect:(Class)effectClass
 {
-    StatusWindow *sw = [StatusWindow sharedWindow];
+    StatusWindow *sw = (StatusWindow *)[StatusWindow sharedWindow];
     
     float time = ([df floatForKey:@"statusWindowVanishSpeed"] ? [df floatForKey:@"statusWindowVanishSpeed"] : 0.8);
     [df setObject:NSStringFromClass(effectClass) forKey:@"statusWindowVanishEffect"];