X-Git-Url: http://git.ithinksw.org/MenuTunes.git/blobdiff_plain/166324bee63502af1f85f9eb1126fbb5db19e0c0..d96f4c2ccb2399470f029aeb3f7957b7fe4aab06:/OldMainController.m?ds=sidebyside

diff --git a/OldMainController.m b/OldMainController.m
index 0d22d9a..7dc107d 100755
--- a/OldMainController.m
+++ b/OldMainController.m
@@ -5,12 +5,13 @@
 
 @interface MainController(Private)
 - (ITMTRemote *)loadRemote;
-- (void)updateMenu;
 - (void)rebuildUpcomingSongsMenu;
 - (void)rebuildPlaylistMenu;
 - (void)rebuildEQPresetsMenu;
+- (void)updateRatingMenu;
 - (void)setupHotKeys;
 - (void)timerUpdate;
+- (void)updateMenu;
 - (void)setKeyEquivalentForCode:(short)code andModifiers:(long)modifiers
         onItem:(NSMenuItem *)item;
 
@@ -20,7 +21,7 @@
 
 /*************************************************************************/
 #pragma mark -
-#pragma mark INITIALIZATION METHODS
+#pragma mark INITIALIZATION/DEALLOCATION METHODS
 /*************************************************************************/
 
 - (id)init
@@ -32,34 +33,62 @@
     return self;
 }
 
+- (void)dealloc
+{
+    if (refreshTimer) {
+        [refreshTimer invalidate];
+        [refreshTimer release];
+        refreshTimer = nil;
+    }
+    [currentRemote halt];
+    [statusItem release];
+    [menu release];
+    [super dealloc];
+}
+
 - (void)applicationDidFinishLaunching:(NSNotification *)note
 {
     currentRemote = [self loadRemote];
     [currentRemote begin];
     
     //Setup for notification of the remote player launching or quitting
-    [[[NSWorkspace sharedWorkspace] notificationCenter] addObserver:self selector:@selector(applicationTerminated:) name:NSWorkspaceDidTerminateApplicationNotification object:nil];
-    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationLaunched:) name:NSWorkspaceDidLaunchApplicationNotification object:nil];
+    [[[NSWorkspace sharedWorkspace] notificationCenter]
+            addObserver:self
+            selector:@selector(applicationTerminated:)
+            name:NSWorkspaceDidTerminateApplicationNotification
+            object:nil];
+    
+    [[[NSWorkspace sharedWorkspace] notificationCenter]
+            addObserver:self
+            selector:@selector(applicationLaunched:)
+            name:NSWorkspaceDidLaunchApplicationNotification
+            object:nil];
     
     [self registerDefaults];
     
-    menu = [[NSMenu alloc] initWithTitle:@""];
+    statusItem = [[ITStatusItem alloc]
+            initWithStatusBar:[NSStatusBar systemStatusBar]
+            withLength:NSSquareStatusItemLength];
     
+    menu = [[NSMenu alloc] initWithTitle:@""];
     if ( ( [currentRemote playerRunningState] == ITMTRemotePlayerRunning ) ) {
         [self applicationLaunched:nil];
     } else {
         [self applicationTerminated:nil];
     }
     
-    statusItem = [[ITStatusItem alloc] initWithStatusBar:[NSStatusBar systemStatusBar] withLength:NSSquareStatusItemLength];
-    
     [statusItem setImage:[NSImage imageNamed:@"menu"]];
     [statusItem setAlternateImage:[NSImage imageNamed:@"selected_image"]];
-    [statusItem setMenu:menu];
     // Below line of code is for creating builds for Beta Testers
     // [statusItem setToolTip:@[NSString stringWithFormat:@"This Nontransferable Beta (Built on %s) of iThink Software's MenuTunes is Registered to: Beta Tester (betatester@somedomain.com).",__DATE__]];
 }
 
+- (void)applicationWillTerminate:(NSNotification *)note
+{
+    [self clearHotKeys];
+    [[NSStatusBar systemStatusBar] removeStatusItem:statusItem];
+}
+
 - (ITMTRemote *)loadRemote
 {
     NSString *folderPath = [[NSBundle mainBundle] builtInPlugInsPath];
@@ -121,7 +150,7 @@
         [notRunningMenu addItem:[NSMenuItem separatorItem]];
         [[notRunningMenu addItemWithTitle:@"Preferences" action:@selector(showPreferences:) keyEquivalent:@""] setTarget:self];
         [[notRunningMenu addItemWithTitle:@"Quit" action:@selector(quitMenuTunes:) keyEquivalent:@""] setTarget:self];
-        [statusItem setMenu:[menu autorelease]];
+        [statusItem setMenu:[notRunningMenu autorelease]];
         
         [refreshTimer invalidate];
         [refreshTimer release];
@@ -132,15 +161,6 @@
     }
 }
 
-- (void)startTimerInNewThread
-{
-    NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
-    NSRunLoop *runLoop = [NSRunLoop currentRunLoop];
-    refreshTimer = [[NSTimer scheduledTimerWithTimeInterval:0.5 target:self selector:@selector(timerUpdate) userInfo:nil repeats:YES] retain];
-    [runLoop run];
-    [pool release];
-}
-
 /*************************************************************************/
 #pragma mark -
 #pragma mark INSTANCE METHODS
@@ -179,7 +199,8 @@
         
         for (i = 0; i < [loginarray count]; i++) {
             NSDictionary *tempDict = [loginarray objectAtIndex:i];
-            if ([[[tempDict objectForKey:@"Path"] lastPathComponent] isEqualToString:[[[NSBundle mainBundle] bundlePath] lastPathComponent]]) {
+            if ([[[tempDict objectForKey:@"Path"] lastPathComponent] isEqualToString:
+                [[[NSBundle mainBundle] bundlePath] lastPathComponent]]) {
                 found = YES;
             }
         }
@@ -228,6 +249,19 @@
     }
 }
 
+- (void)startTimerInNewThread
+{
+    NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+    NSRunLoop *runLoop = [NSRunLoop currentRunLoop];
+    refreshTimer = [[NSTimer scheduledTimerWithTimeInterval:0.5
+                             target:self
+                             selector:@selector(timerUpdate)
+                             userInfo:nil
+                             repeats:YES] retain];
+    [runLoop run];
+    [pool release];
+}
+
 //Recreate the status item menu
 - (void)rebuildMenu
 {
@@ -235,21 +269,32 @@
     int i;
     
     trackInfoIndex = -1;
-    lastSongIndex = -1;
     lastPlaylistIndex = -1;
     didHaveAlbumName = ([[currentRemote currentSongAlbum] length] > 0);
     didHaveArtistName = ([[currentRemote currentSongArtist] length] > 0);
     
-    while ([menu numberOfItems] > 0) {
+    [menu autorelease];
+    menu = [[NSMenu alloc] initWithTitle:@""];
+    
+    /*while ([menu numberOfItems] > 0) {
         [menu removeItemAtIndex:0];
-    }
+    }*/
+    
+    playPauseItem = nil;
+    lastSongIdentifier = @"0-0";
     
-    playPauseMenuItem = nil;
     upcomingSongsItem = nil;
-    songRatingMenuItem = nil;
+    [upcomingSongsMenu release];
+    upcomingSongsMenu = nil;
+    
+    ratingItem = nil;
+    [ratingMenu release];
+    ratingMenu = nil;
+    
     playlistItem = nil;
     [playlistMenu release];
     playlistMenu = nil;
+    
     eqItem = nil;
     [eqMenu release];
     eqMenu = nil;
@@ -258,14 +303,13 @@
         NSString *item = [myMenu objectAtIndex:i];
         if ([item isEqualToString:@"Play/Pause"]) {
             KeyCombo *tempCombo = [[NSUserDefaults standardUserDefaults] keyComboForKey:@"PlayPause"];
-            playPauseMenuItem = [menu addItemWithTitle:@"Play"
+            playPauseItem = [menu addItemWithTitle:@"Play"
                                     action:@selector(playPause:)
                                     keyEquivalent:@""];
-            [playPauseMenuItem setTarget:self];
             
             if (tempCombo) {
                 [self setKeyEquivalentForCode:[tempCombo keyCode]
-                    andModifiers:[tempCombo modifiers] onItem:playPauseMenuItem];
+                    andModifiers:[tempCombo modifiers] onItem:playPauseItem];
                 [tempCombo release];
             }
         } else if ([item isEqualToString:@"Next Track"]) {
@@ -274,7 +318,6 @@
                                         action:@selector(nextSong:)
                                         keyEquivalent:@""];
             
-            [nextTrack setTarget:self];
             if (tempCombo) {
                 [self setKeyEquivalentForCode:[tempCombo keyCode]
                     andModifiers:[tempCombo modifiers] onItem:nextTrack];
@@ -286,20 +329,19 @@
                                         action:@selector(prevSong:)
                                         keyEquivalent:@""];
             
-            [prevTrack setTarget:self];
             if (tempCombo) {
                 [self setKeyEquivalentForCode:[tempCombo keyCode]
                     andModifiers:[tempCombo modifiers] onItem:prevTrack];
                 [tempCombo release];
             }
         } else if ([item isEqualToString:@"Fast Forward"]) {
-            [[menu addItemWithTitle:@"Fast Forward"
+            [menu addItemWithTitle:@"Fast Forward"
                     action:@selector(fastForward:)
-                    keyEquivalent:@""] setTarget:self];
+                    keyEquivalent:@""];
         } else if ([item isEqualToString:@"Rewind"]) {
-            [[menu addItemWithTitle:@"Rewind"
+            [menu addItemWithTitle:@"Rewind"
                     action:@selector(rewind:)
-                    keyEquivalent:@""] setTarget:self];
+                    keyEquivalent:@""];
         } else if ([item isEqualToString:@"Upcoming Songs"]) {
             upcomingSongsItem = [menu addItemWithTitle:@"Upcoming Songs"
                     action:nil
@@ -313,13 +355,13 @@
                     action:nil
                     keyEquivalent:@""];
         } else if ([item isEqualToString:@"PreferencesÉ"]) {
-            [[menu addItemWithTitle:@"PreferencesÉ"
+            [menu addItemWithTitle:@"PreferencesÉ"
                     action:@selector(showPreferences:)
-                    keyEquivalent:@""] setTarget:self];
+                    keyEquivalent:@""];
         } else if ([item isEqualToString:@"Quit"]) {
-            [[menu addItemWithTitle:@"Quit"
+            [menu addItemWithTitle:@"Quit"
                     action:@selector(quitMenuTunes:)
-                    keyEquivalent:@""] setTarget:self];
+                    keyEquivalent:@""];
         } else if ([item isEqualToString:@"Current Track Info"]) {
             trackInfoIndex = [menu numberOfItems];
             [menu addItemWithTitle:@"No Song"
@@ -332,184 +374,42 @@
             NSString *emptyStarChar = [NSString stringWithCharacters:&emptystar length:1];
             NSMenuItem *item;
             
-            songRatingMenuItem = [menu addItemWithTitle:@"Song Rating"
+            ratingItem = [menu addItemWithTitle:@"Song Rating"
                     action:nil
                     keyEquivalent:@""];
             
             ratingMenu = [[NSMenu alloc] initWithTitle:@""];
             
             item = [ratingMenu addItemWithTitle:[NSString stringWithFormat:@"%@%@%@%@%@", emptyStarChar, emptyStarChar, emptyStarChar, emptyStarChar, emptyStarChar] action:@selector(selectSongRating:) keyEquivalent:@""];
-            [item setTarget:self];
             [item setTag:0];
             
             item = [ratingMenu addItemWithTitle:[NSString stringWithFormat:@"%@%@%@%@%@", fullStarChar, emptyStarChar, emptyStarChar, emptyStarChar, emptyStarChar] action:@selector(selectSongRating:) keyEquivalent:@""];
-            [item setTarget:self];
             [item setTag:20];
             
             item = [ratingMenu addItemWithTitle:[NSString stringWithFormat:@"%@%@%@%@%@", fullStarChar, fullStarChar, emptyStarChar, emptyStarChar, emptyStarChar] action:@selector(selectSongRating:) keyEquivalent:@""];
-            [item setTarget:self];
             [item setTag:40];
             
             item = [ratingMenu addItemWithTitle:[NSString stringWithFormat:@"%@%@%@%@%@", fullStarChar, fullStarChar, fullStarChar, emptyStarChar, emptyStarChar] action:@selector(selectSongRating:) keyEquivalent:@""];
-            [item setTarget:self];
             [item setTag:60];
             
             item = [ratingMenu addItemWithTitle:[NSString stringWithFormat:@"%@%@%@%@%@", fullStarChar, fullStarChar, fullStarChar, fullStarChar, emptyStarChar] action:@selector(selectSongRating:) keyEquivalent:@""];
-            [item setTarget:self];
             [item setTag:80];
             
             item = [ratingMenu addItemWithTitle:[NSString stringWithFormat:@"%@%@%@%@%@", fullStarChar, fullStarChar, fullStarChar, fullStarChar, fullStarChar] action:@selector(selectSongRating:) keyEquivalent:@""];
-            [item setTarget:self];
             [item setTag:100];
         } else if ([item isEqualToString:@"<separator>"]) {
             [menu addItem:[NSMenuItem separatorItem]];
         }
     }
     
-    [self timerUpdate]; //Updates dynamic info in the menu
+    [statusItem setMenu:menu];
+    
+    [self updateMenu];
     
     [self clearHotKeys];
     [self setupHotKeys];
 }
 
-//Updates the menu with current player state, song, and upcoming songs
-- (void)updateMenu
-{
-    NSMenuItem *menuItem;
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    
-    if ( ( isAppRunning == ITMTRemotePlayerNotRunning ) ) {
-        return;
-    }
-    
-    if (upcomingSongsItem) {
-        [self rebuildUpcomingSongsMenu];
-    }
-    
-    if (playlistItem) {
-        [self rebuildPlaylistMenu];
-    }
-    
-    if (eqItem) {
-        [self rebuildEQPresetsMenu];
-    }
-    if (trackInfoIndex > -1) {
-        NSString *curSongName, *curAlbumName = @"", *curArtistName = @"";
-        curSongName = [currentRemote currentSongTitle];
-        
-        if ([defaults boolForKey:@"showAlbum"]) {
-            curAlbumName = [currentRemote currentSongAlbum];
-        }
-        
-        if ([defaults boolForKey:@"showArtist"]) {
-            curArtistName = [currentRemote currentSongArtist];
-        }
-        
-        if ([curSongName length] > 0) {
-            int index = [menu indexOfItemWithTitle:@"Now Playing"];
-            if (index > -1) {
-                if ([defaults boolForKey:@"showName"]) {
-                    [menu removeItemAtIndex:index + 1];
-                }
-                if (didHaveAlbumName && [defaults boolForKey:@"showAlbum"]) {
-                    [menu removeItemAtIndex:index + 1];
-                }
-                if (didHaveArtistName && [defaults boolForKey:@"showArtist"]) {
-                    [menu removeItemAtIndex:index + 1];
-                }
-                if ([defaults boolForKey:@"showTime"]) {
-                    [menu removeItemAtIndex:index + 1];
-                }
-            }
-            
-            if (!isPlayingRadio) {
-                if ([defaults boolForKey:@"showTime"]) {
-                    menuItem = [[NSMenuItem alloc] initWithTitle:[NSString stringWithFormat:@"  %@", [currentRemote currentSongLength]]
-                            action:nil
-                            keyEquivalent:@""];
-                    [menu insertItem:menuItem atIndex:trackInfoIndex + 1];
-                    [menuItem release];
-                }
-                
-                if ([curArtistName length] > 0) {
-                    menuItem = [[NSMenuItem alloc] initWithTitle:[NSString stringWithFormat:@"  %@", curArtistName]
-                            action:nil
-                            keyEquivalent:@""];
-                    [menu insertItem:menuItem atIndex:trackInfoIndex + 1];
-                    [menuItem release];
-                }
-                
-                if ([curAlbumName length] > 0) {
-                    menuItem = [[NSMenuItem alloc] initWithTitle:[NSString stringWithFormat:@"  %@", curAlbumName]
-                            action:nil
-                            keyEquivalent:@""];
-                    [menu insertItem:menuItem atIndex:trackInfoIndex + 1];
-                    [menuItem release];
-                }
-                
-                if (songRatingMenuItem) {
-                    int rating = (int)[currentRemote currentSongRating] * 10;
-                    int i;
-                    for (i = 0; i < 5; i++) {
-                        [[ratingMenu itemAtIndex:i] setState:NSOffState];
-                        [[ratingMenu itemAtIndex:i] setTarget:self];
-                    }
-                    [[ratingMenu itemAtIndex:rating / 2] setState:NSOnState];
-                }
-            }
-            
-            if ([defaults boolForKey:@"showName"]) {
-                menuItem = [[NSMenuItem alloc] initWithTitle:[NSString stringWithFormat:@"  %@", curSongName]
-                            action:nil
-                            keyEquivalent:@""];
-                [menu insertItem:menuItem atIndex:trackInfoIndex + 1];
-                [menuItem release];
-            }
-            
-            if (index == -1) {
-                menuItem = [[NSMenuItem alloc] initWithTitle:@"Now Playing" action:nil keyEquivalent:@""];
-                [menu removeItemAtIndex:[menu indexOfItemWithTitle:@"No Song"]];
-                [menu insertItem:menuItem atIndex:trackInfoIndex];
-                [menuItem release];
-                
-                [songRatingMenuItem setSubmenu:ratingMenu];
-                [songRatingMenuItem setEnabled:YES];
-            }
-        } else if ([menu indexOfItemWithTitle:@"No Song"] == -1) {
-            [menu removeItemAtIndex:trackInfoIndex];
-            
-            if ([defaults boolForKey:@"showName"] == YES) {
-                [menu removeItemAtIndex:trackInfoIndex];
-            }
-            
-            if ([defaults boolForKey:@"showTime"] == YES) {
-                [menu removeItemAtIndex:trackInfoIndex];
-            }
-            
-            if (didHaveArtistName && [defaults boolForKey:@"showArtist"]) {
-                [menu removeItemAtIndex:trackInfoIndex];
-            }
-            
-            if (didHaveAlbumName && [defaults boolForKey:@"showAlbum"]) {
-                [menu removeItemAtIndex:trackInfoIndex];
-            }
-            
-            menuItem = [[NSMenuItem alloc] initWithTitle:@"No Song" action:nil keyEquivalent:@""];
-            [menu insertItem:menuItem atIndex:trackInfoIndex];
-            [menuItem release];
-        }
-        
-        if ([defaults boolForKey:@"showArtist"]) {
-            didHaveArtistName = (([curArtistName length] > 0) ? YES : NO);
-        }
-            
-        if ([defaults boolForKey:@"showAlbum"]) {
-            didHaveAlbumName = (([curAlbumName length] > 0) ? YES : NO);
-        }
-    }
-    [menu update];
-}
-
 //Rebuild the upcoming songs submenu. Can be improved a lot.
 - (void)rebuildUpcomingSongsMenu
 {
@@ -531,8 +431,7 @@
                 if (i <= numSongs) {
                     NSString *curSong = [currentRemote songTitleAtIndex:i];
                     NSMenuItem *songItem;
-                    songItem = [[NSMenuItem alloc] initWithTitle:curSong action:@selector(playTrack:) keyEquivalent:@""];
-                    [songItem setTarget:self];
+                    songItem = [[NSMenuItem alloc] initWithTitle:curSong action:@selector(selectSong:) keyEquivalent:@""];
                     [songItem setRepresentedObject:[NSNumber numberWithInt:i]];
                     [upcomingSongsMenu addItem:songItem];
                     [songItem release];
@@ -550,13 +449,7 @@
 - (void)rebuildPlaylistMenu
 {
     NSArray *playlists = [currentRemote playlists];
-    int i, curPlaylist = [currentRemote currentPlaylistIndex];
-    
-    if (isPlayingRadio) {
-        curPlaylist = 0;
-    }
-    if (playlistMenu && ([playlists count] == [playlistMenu numberOfItems]))
-        return;
+    int i, currentPlaylist = [currentRemote currentPlaylistIndex];
     
     [playlistMenu release];
     playlistMenu = [[NSMenu alloc] initWithTitle:@""];
@@ -565,16 +458,15 @@
         NSString *playlistName = [playlists objectAtIndex:i];
         NSMenuItem *tempItem;
         tempItem = [[NSMenuItem alloc] initWithTitle:playlistName action:@selector(selectPlaylist:) keyEquivalent:@""];
-        [tempItem setTarget:self];
-        [tempItem setRepresentedObject:[NSNumber numberWithInt:i + 1]];
+        [tempItem setTag:i + 1];
         [playlistMenu addItem:tempItem];
         [tempItem release];
     }
     [playlistItem setSubmenu:playlistMenu];
     [playlistItem setEnabled:YES];
     
-    if (curPlaylist) {
-        [[playlistMenu itemAtIndex:curPlaylist - 1] setState:NSOnState];
+    if (!isPlayingRadio && currentPlaylist) {
+        [[playlistMenu itemAtIndex:currentPlaylist - 1] setState:NSOnState];
     }
 }
 
@@ -585,228 +477,197 @@
     NSMenuItem *enabledItem;
     int i;
     
-    if (eqMenu && ([[currentRemote eqPresets] count] == [eqMenu numberOfItems]))
-        return;
-    
     [eqMenu release];
     eqMenu = [[NSMenu alloc] initWithTitle:@""];
     
-    enabledItem = [eqMenu addItemWithTitle:@"Disabled"
-                          action:@selector(toggleEqualizer)
+    enabledItem = [eqMenu addItemWithTitle:@"Enabled"
+                          action:@selector(selectEQPreset:)
                           keyEquivalent:@""];
+    [enabledItem setTag:-1];
     
-    if ([currentRemote equalizerEnabled] == NO) {
+    if ([currentRemote equalizerEnabled]) {
         [enabledItem setState:NSOnState];
     }
     
     [eqMenu addItem:[NSMenuItem separatorItem]];
     
     for (i = 0; i < [eqPresets count]; i++) {
-        NSString *setName = [eqPresets objectAtIndex:i];
+        NSString *name = [eqPresets objectAtIndex:i];
         NSMenuItem *tempItem;
-	if (setName) {
-        tempItem = [[NSMenuItem alloc] initWithTitle:setName action:@selector(selectEQPreset:) keyEquivalent:@""];
-        [tempItem setTarget:self];
-        [tempItem setRepresentedObject:[NSNumber numberWithInt:i]];
-        [eqMenu addItem:tempItem];
-        [tempItem release];
+	if (name) {
+            tempItem = [[NSMenuItem alloc] initWithTitle:name action:@selector(selectEQPreset:) keyEquivalent:@""];
+            [tempItem setTag:i];
+            [eqMenu addItem:tempItem];
+            [tempItem release];
 	}
     }
     [eqItem setSubmenu:eqMenu];
+    [eqItem setEnabled:YES];
     
     [[eqMenu itemAtIndex:[currentRemote currentEQPresetIndex] + 1] setState:NSOnState];
 }
 
-- (void)clearHotKeys
+- (void)updateRatingMenu
 {
-    [[HotKeyCenter sharedCenter] removeHotKey:@"PlayPause"];
-    [[HotKeyCenter sharedCenter] removeHotKey:@"NextTrack"];
-    [[HotKeyCenter sharedCenter] removeHotKey:@"PrevTrack"];
-    [[HotKeyCenter sharedCenter] removeHotKey:@"TrackInfo"];
-    [[HotKeyCenter sharedCenter] removeHotKey:@"UpcomingSongs"];
+    int currentSongRating = ([currentRemote currentSongRating] * 5);
+    if ([currentRemote currentPlaylistIndex] && (currentSongRating != lastSongRating)) {
+        if ([currentRemote classOfPlaylistAtIndex:[currentRemote currentPlaylistIndex]] == ITMTRemotePlayerRadioPlaylist) {
+            return;
+        }
+        [[ratingMenu itemAtIndex:lastSongRating] setState:NSOffState];
+        lastSongRating = currentSongRating;
+        [[ratingMenu itemAtIndex:lastSongRating] setState:NSOnState];
+    }
 }
 
-- (void)setupHotKeys
+- (void)timerUpdate
 {
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSString *currentIdentifier = [currentRemote currentSongUniqueIdentifier];
+    if (![lastSongIdentifier isEqualToString:currentIdentifier] ||
+       (!isPlayingRadio && ([currentRemote classOfPlaylistAtIndex:[currentRemote currentPlaylistIndex]] == ITMTRemotePlayerRadioPlaylist))) {
+        [self rebuildMenu];
+    }
     
-    if ([defaults objectForKey:@"PlayPause"] != nil) {
-        [[HotKeyCenter sharedCenter] addHotKey:@"PlayPause"
-                combo:[defaults keyComboForKey:@"PlayPause"]
-                target:self action:@selector(playPause:)];
+    [self updateRatingMenu];
+    
+    //Update Play/Pause menu item
+    if (playPauseItem){
+        if ([currentRemote playerPlayingState] == ITMTRemotePlayerPlaying) {
+            [playPauseItem setTitle:@"Pause"];
+        } else {
+            [playPauseItem setTitle:@"Play"];
+        }
     }
+}
+
+- (void)updateMenu
+{
+    NSUserDefaults *defaults;
+    int playlist = [currentRemote currentPlaylistIndex];
+    int temp;
     
-    if ([defaults objectForKey:@"NextTrack"] != nil) {
-        [[HotKeyCenter sharedCenter] addHotKey:@"NextTrack"
-                combo:[defaults keyComboForKey:@"NextTrack"]
-                target:self action:@selector(nextSong:)];
+    if ( (isAppRunning == ITMTRemotePlayerNotRunning) ) {
+        return;
     }
     
-    if ([defaults objectForKey:@"PrevTrack"] != nil) {
-        [[HotKeyCenter sharedCenter] addHotKey:@"PrevTrack"
-                combo:[defaults keyComboForKey:@"PrevTrack"]
-                target:self action:@selector(prevSong:)];
+    defaults = [NSUserDefaults standardUserDefaults];
+    isPlayingRadio = ([currentRemote classOfPlaylistAtIndex:playlist] == ITMTRemotePlayerRadioPlaylist);
+    
+    if (upcomingSongsItem) {
+        [self rebuildUpcomingSongsMenu];
     }
     
-    if ([defaults objectForKey:@"TrackInfo"] != nil) {
-        [[HotKeyCenter sharedCenter] addHotKey:@"TrackInfo"
-                combo:[defaults keyComboForKey:@"TrackInfo"]
-                target:self action:@selector(showCurrentTrackInfo)];
+    if (playlistItem) {
+        [self rebuildPlaylistMenu];
     }
     
-    if ([defaults objectForKey:@"UpcomingSongs"] != nil) {
-        [[HotKeyCenter sharedCenter] addHotKey:@"UpcomingSongs"
-               combo:[defaults keyComboForKey:@"UpcomingSongs"]
-               target:self action:@selector(showUpcomingSongs)];
+    if (eqItem) {
+        [self rebuildEQPresetsMenu];
     }
-}
-
-//Called when the timer fires.
-- (void)timerUpdate
-{
-    int playlist = [currentRemote currentPlaylistIndex];
-    ITMTRemotePlayerPlayingState playerPlayingState = [currentRemote playerPlayingState];
     
-    if ((playlist > 0) || playerPlayingState != ITMTRemotePlayerStopped) {
-        int trackPlayingIndex = [currentRemote currentSongIndex];
+    if (ratingItem) {
+        if (isPlayingRadio || !playlist) {
+            [ratingItem setEnabled:NO];
+            if ([ratingItem submenu]) {
+                [ratingItem setSubmenu:nil];
+            }
+        } else {
+            int currentSongRating = ([currentRemote currentSongRating] * 5);
+            [[ratingMenu itemAtIndex:lastSongRating] setState:NSOffState];
+            lastSongRating = currentSongRating;
+            [[ratingMenu itemAtIndex:lastSongRating] setState:NSOnState];
+            [ratingItem setEnabled:YES];
+            [ratingItem setSubmenu:ratingMenu];
+        }
+    }
+    
+    //Set the new unique song identifier
+    lastSongIdentifier = [[currentRemote currentSongUniqueIdentifier] retain];
+    
+    //If we're in a playlist or radio mode
+    if ( (trackInfoIndex > -1) && (playlist || isPlayingRadio) ) {
+        NSString *title, *album, *artist;
+        
+        if ( (temp = [menu indexOfItemWithTitle:@"No Song"]) && (temp > -1) ) {
+            [menu removeItemAtIndex:temp];
+            [menu insertItemWithTitle:@"Now Playing" action:NULL keyEquivalent:@"" atIndex:temp];
+        }
         
-        if (trackPlayingIndex != lastSongIndex) {
-            BOOL wasPlayingRadio = isPlayingRadio;
-            isPlayingRadio = ([currentRemote classOfPlaylistAtIndex:playlist] == ITMTRemotePlayerRadioPlaylist);
+        title = [currentRemote currentSongTitle];
+        
+        if (!isPlayingRadio) {
+            ([defaults boolForKey:@"showAlbum"]) ? (album = [currentRemote currentSongAlbum]) :
+                                                   (album = @"");
+            ([defaults boolForKey:@"showArtist"]) ? (artist = [currentRemote currentSongArtist]) :
+                                                    (artist = @"");
+            if ([defaults boolForKey:@"showTime"]) {
+                [menu insertItemWithTitle:[NSString stringWithFormat:@"  %@", [currentRemote currentSongLength]] action:nil keyEquivalent:@"" atIndex:trackInfoIndex + 1];
+            }
             
-            if (isPlayingRadio && !wasPlayingRadio) {
-                int i;
-                for (i = 0; i < [playlistMenu numberOfItems]; i++)
-                {
-                    [[playlistMenu itemAtIndex:i] setState:NSOffState];
-                }
-            } else {
-                [[playlistMenu itemAtIndex:playlist - 1] setState:NSOnState];
+            if ([artist length] > 0) {
+                [menu insertItemWithTitle:[NSString stringWithFormat:@"  %@", artist] action:nil keyEquivalent:@"" atIndex:trackInfoIndex + 1];
             }
             
-            if (wasPlayingRadio) {
-                NSMenuItem *temp = [[NSMenuItem alloc] initWithTitle:@"" action:NULL keyEquivalent:@""];
-                [menu insertItem:temp atIndex:trackInfoIndex + 1];
-                [temp release];
+            if ([album length] > 0) {
+                [menu insertItemWithTitle:[NSString stringWithFormat:@"  %@", album] action:nil keyEquivalent:@"" atIndex:trackInfoIndex + 1];
             }
             
-            [self updateMenu];
-            lastSongIndex = trackPlayingIndex;
-        } else {
-            if (playlist != lastPlaylistIndex) {
-                BOOL wasPlayingRadio = isPlayingRadio;
-                isPlayingRadio = ([currentRemote classOfPlaylistAtIndex:playlist] == ITMTRemotePlayerRadioPlaylist);
-                
-                if (isPlayingRadio && !wasPlayingRadio) {
-                    int i;
-                    for (i = 0; i < [playlistMenu numberOfItems]; i++) {
-                        [[playlistMenu itemAtIndex:i] setState:NSOffState];
-                    }
-                }
-                
-                if (wasPlayingRadio) {
-                    NSMenuItem *temp = [[NSMenuItem alloc] initWithTitle:@"" action:NULL keyEquivalent:@""];
-                    [menu insertItem:temp atIndex:trackInfoIndex + 1];
-                    [temp release];
-                }
-                
-                if (!isPlayingRadio) {
-                    int i;
-                    for (i = 0; i < [playlistMenu numberOfItems]; i++)
-                    {
-                        [[playlistMenu itemAtIndex:i] setState:NSOffState];
-                    }
-                    [[playlistMenu itemAtIndex:playlist - 1] setState:NSOnState];
-                }
-                
-                [self updateMenu];
-                lastSongIndex = trackPlayingIndex;
-                lastPlaylistIndex = playlist;
+            if ([defaults boolForKey:@"showArtist"]) {
+                didHaveArtistName = (([artist length] > 0) ? YES : NO);
             }
-        }
-        //Update Play/Pause menu item
-        if (playPauseMenuItem){
-            if (playerPlayingState == ITMTRemotePlayerPlaying) {
-                [playPauseMenuItem setTitle:@"Pause"];
-            } else {
-                [playPauseMenuItem setTitle:@"Play"];
+            
+            if ([defaults boolForKey:@"showAlbum"]) {
+                didHaveAlbumName = (([album length] > 0) ? YES : NO);
             }
         }
-    } else if ((lastPlaylistIndex > 0) && (playlist == 0)) {
-        NSMenuItem *menuItem;
-        NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-        //Remote the now playing item and add no song item
-        [menu removeItemAtIndex:trackInfoIndex];
-        
-        if ([defaults boolForKey:@"showName"] == YES) {
-            [menu removeItemAtIndex:trackInfoIndex];
-        }
-        
-        if ([defaults boolForKey:@"showTime"] == YES) {
-            [menu removeItemAtIndex:trackInfoIndex];
-        }
-        
-        if (didHaveArtistName && [defaults boolForKey:@"showArtist"]) {
-            [menu removeItemAtIndex:trackInfoIndex];
-        }
         
-        if (didHaveAlbumName && [defaults boolForKey:@"showAlbum"]) {
-            [menu removeItemAtIndex:trackInfoIndex];
+        if ([title length] > 0) {
+            [menu insertItemWithTitle:[NSString stringWithFormat:@"  %@", title] action:nil keyEquivalent:@"" atIndex:trackInfoIndex + 1];
         }
-        
-        [playPauseMenuItem setTitle:@"Play"];
-        
-        didHaveArtistName = NO;
-        didHaveAlbumName = NO;
-        lastPlaylistIndex = -1;
-        lastSongIndex = -1;
-        
-        [upcomingSongsItem setSubmenu:nil];
-        [upcomingSongsItem setEnabled:NO];
-        
-        [songRatingMenuItem setSubmenu:nil];
-        [songRatingMenuItem setEnabled:NO];
-        
-        menuItem = [[NSMenuItem alloc] initWithTitle:@"No Song" action:nil keyEquivalent:@""];
-        [menu insertItem:menuItem atIndex:trackInfoIndex];
-        [menuItem release];
     }
+    [menu update];
 }
 
+
 //
 //
-// Selectors - called from status item menu
+// Menu Selectors
 //
 //
 
-// Plugin dependent selectors
-
-- (void)playTrack:(id)sender
+- (void)selectSong:(id)sender
 {
     [currentRemote switchToSongAtIndex:[[sender representedObject] intValue]];
 }
 
 - (void)selectPlaylist:(id)sender
 {
-    int playlist = [[sender representedObject] intValue];
-    if (!isPlayingRadio) {
-        int curPlaylist = [currentRemote currentPlaylistIndex];
-        if (curPlaylist > 0) {
-            [[playlistMenu itemAtIndex:curPlaylist - 1] setState:NSOffState];
-        }
-    }
+    int playlist = [sender tag];
     [currentRemote switchToPlaylistAtIndex:playlist];
-    [[playlistMenu itemAtIndex:playlist - 1] setState:NSOnState];
-    [self updateMenu];
 }
 
 - (void)selectEQPreset:(id)sender
 {
     int curSet = [currentRemote currentEQPresetIndex];
-    int item = [[sender representedObject] intValue];
-    [currentRemote switchToEQAtIndex:item];
-    [[eqMenu itemAtIndex:curSet + 1] setState:NSOffState];
-    [[eqMenu itemAtIndex:item + 2] setState:NSOnState];
+    int item = [sender tag];
+    
+    if (item == -1) {
+        [currentRemote setEqualizerEnabled:![currentRemote equalizerEnabled]];
+    } else {
+        [currentRemote setEqualizerEnabled:YES];
+        [currentRemote switchToEQAtIndex:item];
+        [[eqMenu itemAtIndex:curSet + 1] setState:NSOffState];
+        [[eqMenu itemAtIndex:item + 2] setState:NSOnState];
+    }
+}
+
+- (void)selectSongRating:(id)sender
+{
+    int newRating = [sender tag];
+    [[ratingMenu itemAtIndex:lastSongRating] setState:NSOffState];
+    [sender setState:NSOnState];
+    [currentRemote setCurrentSongRating:(float)newRating / 100.0];
+    lastSongRating = newRating / 20;
 }
 
 - (void)playPause:(id)sender
@@ -815,13 +676,13 @@
     
     if (state == ITMTRemotePlayerPlaying) {
         [currentRemote pause];
-        [playPauseMenuItem setTitle:@"Play"];
+        [playPauseItem setTitle:@"Play"];
     } else if ((state == ITMTRemotePlayerForwarding) || (state == ITMTRemotePlayerRewinding)) {
         [currentRemote pause];
         [currentRemote play];
     } else {
         [currentRemote play];
-        [playPauseMenuItem setTitle:@"Pause"];
+        [playPauseItem setTitle:@"Pause"];
     }
 }
 
@@ -838,30 +699,15 @@
 - (void)fastForward:(id)sender
 {
     [currentRemote forward];
-    [playPauseMenuItem setTitle:@"Play"];
+    [playPauseItem setTitle:@"Play"];
 }
 
 - (void)rewind:(id)sender
 {
     [currentRemote rewind];
-    [playPauseMenuItem setTitle:@"Play"];
-}
-
-- (void)toggleEqualizer
-{
-    [currentRemote setEqualizerEnabled:![currentRemote equalizerEnabled]];
+    [playPauseItem setTitle:@"Play"];
 }
 
-- (void)selectSongRating:(id)sender
-{
-    [[ratingMenu itemAtIndex:([currentRemote currentSongRating] / 20)] setState:NSOffState];
-    [currentRemote setCurrentSongRating:(float)[sender tag] / 100.0];
-    [sender setState:NSOnState];
-}
-
-//
-//
-// Plugin independent selectors
 //
 //
 - (void)quitMenuTunes:(id)sender
@@ -869,6 +715,17 @@
     [NSApp terminate:self];
 }
 
+- (void)showPlayer:(id)sender
+{
+    if ( ( isAppRunning == ITMTRemotePlayerRunning) ) {
+        [currentRemote showPrimaryInterface];
+    } else {
+        if (![[NSWorkspace sharedWorkspace] launchApplication:[currentRemote playerFullName]]) {
+            NSLog(@"Error Launching Player");
+        }
+    }
+}
+
 - (void)showPreferences:(id)sender
 {
     if (!prefsController) {
@@ -886,17 +743,56 @@
     prefsController = nil;
 }
 
-- (void)showPlayer:(id)sender
+
+//
+//
+// Hot key setup
+//
+//
+
+- (void)clearHotKeys
 {
-    if ( ( isAppRunning == ITMTRemotePlayerRunning) ) {
-        [currentRemote showPrimaryInterface];
-    } else {
-        if (![[NSWorkspace sharedWorkspace] launchApplication:[currentRemote playerFullName]]) {
-            NSLog(@"Error Launching Player");
-        }
+    [[HotKeyCenter sharedCenter] removeHotKey:@"PlayPause"];
+    [[HotKeyCenter sharedCenter] removeHotKey:@"NextTrack"];
+    [[HotKeyCenter sharedCenter] removeHotKey:@"PrevTrack"];
+    [[HotKeyCenter sharedCenter] removeHotKey:@"TrackInfo"];
+    [[HotKeyCenter sharedCenter] removeHotKey:@"UpcomingSongs"];
+}
+
+- (void)setupHotKeys
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    
+    if ([defaults objectForKey:@"PlayPause"] != nil) {
+        [[HotKeyCenter sharedCenter] addHotKey:@"PlayPause"
+                combo:[defaults keyComboForKey:@"PlayPause"]
+                target:self action:@selector(playPause:)];
+    }
+    
+    if ([defaults objectForKey:@"NextTrack"] != nil) {
+        [[HotKeyCenter sharedCenter] addHotKey:@"NextTrack"
+                combo:[defaults keyComboForKey:@"NextTrack"]
+                target:self action:@selector(nextSong:)];
+    }
+    
+    if ([defaults objectForKey:@"PrevTrack"] != nil) {
+        [[HotKeyCenter sharedCenter] addHotKey:@"PrevTrack"
+                combo:[defaults keyComboForKey:@"PrevTrack"]
+                target:self action:@selector(prevSong:)];
+    }
+    
+    if ([defaults objectForKey:@"TrackInfo"] != nil) {
+        [[HotKeyCenter sharedCenter] addHotKey:@"TrackInfo"
+                combo:[defaults keyComboForKey:@"TrackInfo"]
+                target:self action:@selector(showCurrentTrackInfo)];
+    }
+    
+    if ([defaults objectForKey:@"UpcomingSongs"] != nil) {
+        [[HotKeyCenter sharedCenter] addHotKey:@"UpcomingSongs"
+               combo:[defaults keyComboForKey:@"UpcomingSongs"]
+               target:self action:@selector(showUpcomingSongs)];
     }
 }
-        
 
 //
 //
@@ -1167,35 +1063,4 @@
     }
 }
 
-/*************************************************************************/
-#pragma mark -
-#pragma mark NSApplication DELEGATE METHODS
-/*************************************************************************/
-
-- (void)applicationWillTerminate:(NSNotification *)note
-{
-    [self clearHotKeys];
-    [[NSStatusBar systemStatusBar] removeStatusItem:statusItem];
-}
-
-
-/*************************************************************************/
-#pragma mark -
-#pragma mark DEALLOCATION METHODS
-/*************************************************************************/
-
-- (void)dealloc
-{
-    if (refreshTimer) {
-        [refreshTimer invalidate];
-        [refreshTimer release];
-        refreshTimer = nil;
-    }
-    [currentRemote halt];
-    [statusItem release];
-    [menu release];
-//  [view release];
-    [super dealloc];
-}
-
 @end