Added notes to the TODO. Matt, please check and modify TODO as required :)

[MenuTunes.git] / MainController.m

diff --git a/MainController.m b/MainController.m
index 600d8df..d7dfa6f 100755 (executable)
--- a/MainController.m
+++ b/MainController.m
@@ -1,4 +1,4 @@
-#import "NewMainController.h"
+#import "MainController.h"
 #import "MenuController.h"
 #import "PreferencesController.h"
 #import "HotKeyCenter.h"
@@ -7,11 +7,9 @@
 
 @interface MainController(Private)
 - (ITMTRemote *)loadRemote;
-- (void)setupHotKeys;
 - (void)timerUpdate;
 - (void)setLatestSongIdentifier:(NSString *)newIdentifier;
 - (void)showCurrentTrackInfo;
-
 - (void)applicationLaunched:(NSNotification *)note;
 - (void)applicationTerminated:(NSNotification *)note;
 @end
@@ -161,9 +159,12 @@ static MainController *sharedController;
 
 - (void)timerUpdate
 {
-    if ( ( [self songChanged] ) ||
+    //This huge if statement is being nasty
+    /*if ( ( [self songChanged] ) ||
          ( ([self radioIsPlaying]) && (latestPlaylistClass != ITMTRemotePlayerRadioPlaylist) ) ||
-         ( (! [self radioIsPlaying]) && (latestPlaylistClass == ITMTRemotePlayerRadioPlaylist) ) ) {
+         ( (! [self radioIsPlaying]) && (latestPlaylistClass == ITMTRemotePlayerRadioPlaylist) ) )*/
+    
+    if ([self songChanged]) {
         [self setLatestSongIdentifier:[currentRemote currentSongUniqueIdentifier]];
         latestPlaylistClass = [currentRemote currentPlaylistClass];
         [menuController rebuildSubmenus];
@@ -249,7 +250,7 @@ static MainController *sharedController;
         [currentRemote showPrimaryInterface];
     } else {
         if (![[NSWorkspace sharedWorkspace] launchApplication:[currentRemote playerFullName]]) {
-            NSLog(@"Error Launching Player");
+            NSLog(@"MenuTunes: Error Launching Player");
         }
     }
 }
@@ -292,6 +293,7 @@ static MainController *sharedController;
     [[HotKeyCenter sharedCenter] removeHotKey:@"NextTrack"];
     [[HotKeyCenter sharedCenter] removeHotKey:@"PrevTrack"];
     [[HotKeyCenter sharedCenter] removeHotKey:@"TrackInfo"];
+    [[HotKeyCenter sharedCenter] removeHotKey:@"ShowPlayer"];
     [[HotKeyCenter sharedCenter] removeHotKey:@"UpcomingSongs"];
     [[HotKeyCenter sharedCenter] removeHotKey:@"ToggleLoop"];
     [[HotKeyCenter sharedCenter] removeHotKey:@"ToggleShuffle"];
@@ -321,6 +323,12 @@ static MainController *sharedController;
                 target:self action:@selector(prevSong)];
     }
     
+    if ([df objectForKey:@"ShowPlayer"] != nil) {
+        [[HotKeyCenter sharedCenter] addHotKey:@"ShowPlayer"
+                combo:[df keyComboForKey:@"ShowPlayer"]
+                target:self action:@selector(showPlayer)];
+    }
+    
     if ([df objectForKey:@"TrackInfo"] != nil) {
         [[HotKeyCenter sharedCenter] addHotKey:@"TrackInfo"
                 combo:[df keyComboForKey:@"TrackInfo"]
@@ -411,7 +419,7 @@ static MainController *sharedController;
                                              trackTotal:trackTotal
                                                  rating:rating];
     } else {
-        title = @"No song is playing.";
+        title = NSLocalizedString(@"noSongPlaying", @"No song is playing.");
         [statusWindowController showSongWindowWithTitle:title
                                                   album:nil
                                                  artist:nil
@@ -442,7 +450,7 @@ static MainController *sharedController;
         [statusWindowController showUpcomingSongsWithTitles:songList];
         
     } else {
-        [statusWindowController showUpcomingSongsWithTitles:[NSArray arrayWithObject:@"No upcoming songs."]];
+        [statusWindowController showUpcomingSongsWithTitles:[NSArray arrayWithObject:NSLocalizedString(@"noUpcomingSongs", @"No upcoming songs.")]];
     }
 }
 
@@ -456,6 +464,7 @@ static MainController *sharedController;
     [currentRemote setVolume:volume];
     
     //Show volume status window
+    [statusWindowController showVolumeWindowWithLevel:volume];
 }
 
 - (void)decrementVolume
@@ -468,6 +477,7 @@ static MainController *sharedController;
     [currentRemote setVolume:volume];
     
     //Show volume status window
+    [statusWindowController showVolumeWindowWithLevel:volume];
 }
 
 - (void)incrementRating
@@ -480,6 +490,7 @@ static MainController *sharedController;
     [currentRemote setCurrentSongRating:rating];
     
     //Show rating status window
+    [statusWindowController showRatingWindowWithLevel:rating];
 }
 
 - (void)decrementRating
@@ -492,6 +503,7 @@ static MainController *sharedController;
     [currentRemote setCurrentSongRating:rating];
     
     //Show rating status window
+    [statusWindowController showRatingWindowWithLevel:rating];
 }
 
 - (void)toggleLoop
@@ -512,12 +524,15 @@ static MainController *sharedController;
     [currentRemote setRepeatMode:repeatMode];
     
     //Show loop status window
+    [statusWindowController showLoopWindowWithMode:repeatMode];
 }
 
 - (void)toggleShuffle
 {
-    [currentRemote setShuffleEnabled:![currentRemote shuffleEnabled]];
+    bool newShuffleEnabled = ![currentRemote shuffleEnabled];
+    [currentRemote setShuffleEnabled:newShuffleEnabled];
     //Show shuffle status window
+    [statusWindowController showLoopWindowWithMode:newShuffleEnabled];
 }
 
 /*************************************************************************/
@@ -528,9 +543,15 @@ static MainController *sharedController;
 - (void)applicationLaunched:(NSNotification *)note
 {
     if (!note || [[[note userInfo] objectForKey:@"NSApplicationName"] isEqualToString:[currentRemote playerFullName]]) {
+        [currentRemote begin];
         [self setLatestSongIdentifier:@""];
         [self timerUpdate];
-        [NSThread detachNewThreadSelector:@selector(startTimerInNewThread) toTarget:self withObject:nil];
+        refreshTimer = [[NSTimer scheduledTimerWithTimeInterval:0.5
+                             target:self
+                             selector:@selector(timerUpdate)
+                             userInfo:nil
+                             repeats:YES] retain];
+        //[NSThread detachNewThreadSelector:@selector(startTimerInNewThread) toTarget:self withObject:nil];
         [self setupHotKeys];
         playerRunningState = ITMTRemotePlayerRunning;
     }
@@ -539,11 +560,12 @@ static MainController *sharedController;
  - (void)applicationTerminated:(NSNotification *)note
  {
      if (!note || [[[note userInfo] objectForKey:@"NSApplicationName"] isEqualToString:[currentRemote playerFullName]]) {
-         [refreshTimer invalidate];
-         [refreshTimer release];
-         refreshTimer = nil;
-         [self clearHotKeys];
-         playerRunningState = ITMTRemotePlayerNotRunning;
+        [currentRemote halt];
+        [refreshTimer invalidate];
+        [refreshTimer release];
+        refreshTimer = nil;
+        [self clearHotKeys];
+        playerRunningState = ITMTRemotePlayerNotRunning;
      }
  }
 
@@ -567,13 +589,7 @@ static MainController *sharedController;
 
 - (void)dealloc
 {
-    if (refreshTimer) {
-        [refreshTimer invalidate];
-        [refreshTimer release];
-        refreshTimer = nil;
-    }
-    
-    [currentRemote halt];
+    [self applicationTerminated:nil];
     [statusItem release];
     [statusWindowController release];
     [menuController release];